Skip to content

Announce multiple simultaneous poll closings with one message #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MeMyselfMirai wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Announce multiple simultaneous poll closings with one message #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions constitutional.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ func GetEligibleVoters() []string {
func EvaluatePolls() {
ctx := context.Background()
polls, err := database.GetOpenGatekeepPolls(ctx)
var closedPolls []*database.Poll
if err != nil {
logging.Logger.WithFields(logrus.Fields{"method": "EvaluatePolls getOpen"}).Error(err)
return
Expand Down Expand Up @@ -151,16 +152,31 @@ func EvaluatePolls() {
logging.Logger.WithFields(logrus.Fields{"method": "EvaluatePolls close"}).Error(err)
continue
}
announceStr := "The vote \"" + poll.ShortDescription + "\" has closed."
closedPolls = append(closedPolls, poll)
}

if len(closedPolls) == 0 {
return;
}

// Announce all closed polls with one announcement.
announceStr := ""
if len(closedPolls) > 1 {
announceStr += "Updates on " + strconv.Itoa(len(closedPolls)) + " polls:\n\n"
}
for _, poll := range closedPolls {
pollLink := VOTE_HOST + "/poll/" + poll.Id
announceStr += "The vote \"" + poll.ShortDescription + "\" has closed."
if !poll.Hidden {
announceStr += " Check out the results at " + pollLink
} else {
announceStr += " Results will be posted shortly."
}
_, _, _, err = slackData.Client.SendMessage(slackData.AnnouncementsChannel,
slack.MsgOptionText(announceStr, false))
if err != nil {
logging.Logger.WithFields(logrus.Fields{"method": "EvaluatePolls announce"}).Error(err)
}
announceStr += "\n"
}
_, _, _, err = slackData.Client.SendMessage(slackData.AnnouncementsChannel,
slack.MsgOptionText(announceStr, false))
if err != nil {
logging.Logger.WithFields(logrus.Fields{"method": "EvaluatePolls announce"}).Error(err)
}
}