From c857ca7362d5353e954129d2cd49c9811cfdb8f4 Mon Sep 17 00:00:00 2001 From: Shreelakshmi Iyengar Date: Tue, 10 Mar 2026 12:09:13 +0000 Subject: [PATCH 1/4] fix: change default from 3 to None --- src/blueapi/worker/task_worker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/blueapi/worker/task_worker.py b/src/blueapi/worker/task_worker.py index e52ceed89..68f7083c2 100644 --- a/src/blueapi/worker/task_worker.py +++ b/src/blueapi/worker/task_worker.py @@ -656,7 +656,7 @@ def _on_status_event( initial=initial, target=target, unit=unit or "units", - precision=precision or 3, + precision=precision or None, done=status.done, percentage=percentage, time_elapsed=time_elapsed, From d4b4b428f6b410a381782c40c4032025d3db5b0c Mon Sep 17 00:00:00 2001 From: Shreelakshmi Iyengar Date: Tue, 10 Mar 2026 14:03:05 +0000 Subject: [PATCH 2/4] refactor: remove None from precision line --- src/blueapi/worker/task_worker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/blueapi/worker/task_worker.py b/src/blueapi/worker/task_worker.py index 68f7083c2..adcfe366d 100644 --- a/src/blueapi/worker/task_worker.py +++ b/src/blueapi/worker/task_worker.py @@ -656,7 +656,7 @@ def _on_status_event( initial=initial, target=target, unit=unit or "units", - precision=precision or None, + precision=precision, done=status.done, percentage=percentage, time_elapsed=time_elapsed, From 970139756dfdfa111f0ccaefdca8bf16fe83890e Mon Sep 17 00:00:00 2001 From: Shreelakshmi Iyengar Date: Tue, 10 Mar 2026 14:12:31 +0000 Subject: [PATCH 3/4] refactor: change precision default to None in class StatusView --- src/blueapi/worker/event.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/blueapi/worker/event.py b/src/blueapi/worker/event.py index ad2d33205..801a1e80c 100644 --- a/src/blueapi/worker/event.py +++ b/src/blueapi/worker/event.py @@ -114,7 +114,7 @@ class StatusView(BlueapiBaseModel): ) unit: str = Field(description="Units of progress", default="units") precision: int = Field( - description="Sensible precision of progress to display", default=3 + description="Sensible precision of progress to display", default=None ) done: bool = Field( description="Whether the operation this status describes is complete", From a5d0f61eb159810db68853595197eafff1129e22 Mon Sep 17 00:00:00 2001 From: Shreelakshmi Iyengar Date: Tue, 10 Mar 2026 14:21:08 +0000 Subject: [PATCH 4/4] refactor: add None to type hint of precision in class StatusView --- src/blueapi/worker/event.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/blueapi/worker/event.py b/src/blueapi/worker/event.py index 801a1e80c..367464457 100644 --- a/src/blueapi/worker/event.py +++ b/src/blueapi/worker/event.py @@ -113,7 +113,7 @@ class StatusView(BlueapiBaseModel): description="Target value operation of progress, if known", default=None ) unit: str = Field(description="Units of progress", default="units") - precision: int = Field( + precision: int | None = Field( description="Sensible precision of progress to display", default=None ) done: bool = Field(