Move legacy out from unit tests

[nettle]

Describe the task

We have old legacy tests which are more synthetic tests rather than unit tests.
We should not confuse and mix legacy with real unittests.

Scope

1. Move test/unit/legacy to test/legacy
2. Make sure nothing is broken

Definition of Done

• New location is test/legacy
• All tests pass, nothing is broken

[Szelethus]

Reading the other tests, they dissect the input of the bazel call a lot more thoroughly, but are otherwise not that different from legacy tests. I don't think that in practice legacy tests are different enough to justify moving it out of unit/, not until we decide on some larger restructuring of out tests.

For instance, we could create a functional/ directory where we move tests that simply execute bazel build or bazel test calls, and leave the actual unit tests of our python scripts in unit/. In that case sure, legacy tests should be in functional/ instead.

[nettle]

Reading the other tests, they dissect the input of the bazel call a lot more thoroughly, but are otherwise not that different from legacy tests. I don't think that in practice legacy tests are different enough to justify moving it out of unit/, not until we decide on some larger restructuring of out tests.

For instance, we could create a functional/ directory where we move tests that simply execute bazel build or bazel test calls, and leave the actual unit tests of our python scripts in unit/. In that case sure, legacy tests should be in functional/ instead.

Tests in test/unit are (or at least should be) real unit tests to exercise preferably all features separately.
Even today unit tests are quite complex and sometimes incomprehensible, which is fine - it is very difficult to make them simple.
And the structure of test/unit looks good to me!
Meanwhile legacy is something very simple and, at the same time, does not verify particular features or functionalities.
So, I dont think legacy is a good fit for functional tests, and for unit.
We might treat legacy as smoke tests though... at least I do :) But, well, they are not really smoke tests either.

[furtib]

Do note that none of the unit tests are unittests in a strictly speaking sense.
I believe there is no way to directly call any function from Bazel (in python), and none is called from the template scripts.

If we want to move all tests calling bazel build/test, we should just rename the unit folder to functional.