Add support of the DUMP with all data types

[ggyuchive]

Search before asking

• I had searched in the issues and found no similar issues.

Motivation

Currently in kvrocks, DUMP command is supported in string, bitmap, hash, list, set, zset.
However it's not supported in other types. Basically in redis, it supports DUMP with all types.

e.g. dump bloom-filter type

kvrocks

127.0.0.1:6666> bf.reserve bfkey 0.01 100
OK
127.0.0.1:6666> dump bfkey
(error) ERR Invalid or Not supported object type
127.0.0.1:6666>

Redis

127.0.0.1:6379> bf.reserve bfkey 0.01 100
OK
127.0.0.1:6379> dump bfkey
"\a\x810\x16\xe5\xa2\x89\xbe\xf8\x04\x02\x00\x02\x01\x02\x05\x02\x02\x02@d\x04{\x14\xaeG\xe1zt?\x02\b\x04\xe9\x86/\xb25\x0e&@\x02D\x80\x02\x00\x05\xc3\t@\x90\x01\x00\x00\xe0\x83\x00\x01\x00\x00\x02\x00\x00\x0c\x007\x92(\xde\x13H\xb8\xac"
127.0.0.1:6379>

Solution

Add to support DUMP with all types which implemented in kvrocks.

• SortedInt feat(rdb): add DUMP support for SortedInt type #3366
• Stream
• BloomFilter
• Json
• HyperLogLog
• TDigest
• TimeSeries

Are you willing to submit a PR?

• I'm willing to submit a PR!

[PragmaTwice]

looks good to me. you can open one PR for each data type to make the PR minimal.

[ggyuchive]

looks good to me. you can open one PR for each data type to make the PR minimal.

Okay, then if anyone like to contribute on this issue, feel free to open sub-issue and PR!

[Zakir032002]

I'd like to contribute for this -> DUMP support for SortedInt as a sub-task of this issue and continue

[Zakir032002]

Hi! @PragmaTwice and @ggyuchive

I followed the existing Bitmap pattern and serialized SortedInt as a Redis-native Set so DUMP is Redis-compatible and non-erroring, with type coercion on RESTORE.

Is this the intended approach for Kvrocks-specific types in #3319, or should type preservation be handled differently?