Skip to content

Make Connection’s parsedStatements a prototypeless object #3625

@brianc

Description

@brianc

make Connection’s parsedStatements a prototypeless object

(= namedQueries on the native Client)

Maybe nobody has ever tried to prepare a query with name: 'constructor' (let alone the more obscure options on Object.prototype), and maybe nobody ever will, but it would be nice not to have to think about this anymore. Technically a breaking change for anyone who’s reaching into pg internals to do an inadvisable client.connection.parsedStatements.hasOwnProperty(…) check, for example.

Originally posted by @charmander in #3598 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions