fix bug：std::vector初始化后再emplace导致vector大小翻倍的问题#674
Open
CChuancey wants to merge 1 commit intochenshuo:cpp17from
Open
fix bug：std::vector初始化后再emplace导致vector大小翻倍的问题#674CChuancey wants to merge 1 commit intochenshuo:cpp17from
CChuancey wants to merge 1 commit intochenshuo:cpp17from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpp17 分支中的muduo/base/tests/BoundedBlockingQueue_test.cc 在运行时会直接core dump，考虑是vector在构造函数指定了大小后，又进行emplace操作，这会使vector大小翻倍，且初始化的内容全为空，后面线程在运行时就会core dump。