waveshare_rp2040_lora_companion_radio_usb build issue on firmware 1.14.1 (with SOLUTION!)

[thomasgoehler]

On firmware 1.14.1, building waveshare_rp2040_lora_companion_radio_usb failed because PlatformIO included unnecessary BLE and WiFi dependencies.

The issue was fixed by adding this to platformio.ini(add lib_ignore):

[env:waveshare_rp2040_lora_companion_radio_usb]
extends = waveshare_rp2040_lora
build_flags = ${waveshare_rp2040_lora.build_flags}
  -D MAX_CONTACTS=100
  -D MAX_GROUP_CHANNELS=8
; NOTE: DO NOT ENABLE -->  -D MESH_PACKET_LOGGING=1
; NOTE: DO NOT ENABLE -->  -D MESH_DEBUG=1
build_src_filter = ${waveshare_rp2040_lora.build_src_filter}
  +<../examples/companion_radio/*.cpp>
lib_deps = ${waveshare_rp2040_lora.lib_deps}
  densaugeo/base64 @ ~1.4.0
lib_ignore = 
  BLE
  WiFi

[JDat]

The only question remain: which PR push monkey ( @weebl2000, @robekl anybody else with his dirty hands? ) break MeshCore code up to state that it won't compile for RP2040?

@thomasgoehler thanks a lot for finding/fixing this

PS: @thomasgoehler try to use pico instead of picow in board definition, this make firmware ~2 times smaller and remove unnecessary WiFi stuff, if needed.

[robekl]

which PR push monkey ...

I don't understand what this means, but it sounds like it's intended to be hostile or derogatory toward contributors. Is that the intent? Is the goal here to reduce the number of people involved in the project?

Anyway, a little analysis shows that the breakage wasn't any change that was involved in:

The actual commit that broke it is upstream in earlephilhower/arduino-pico:

• 6f640bf (Release 5.0.0 - FreeRTOS + WiFi support and audio available/write fixes)
• That release explicitly says WiFi support was expanded and “Bluetooth is also supported”
• Source: https://github.com/earlephilhower/arduino-pico/releases

Why that matters here:

• MeshCore’s RP2040 target uses an unpinned GitHub PlatformIO platform
• So old MeshCore commits are rebuilt against newer RP2040 core/platform code over time
• Current build output shows it is using:
  • framework-arduinopico @ 1.50501.0+sha.275e73d
• With that newer core, PlatformIO now sees WiFi and BLE as compatible RP2040 libraries and pulls them into the Waveshare target
• That is why something that previously built can fail later without a MeshCore change

So the answer is:

• MeshCore repo commit: no verified first-bad commit
• Actual breaking commit: upstream earlephilhower/arduino-pico 6f640bf

Current reproduced failure still matches the comment exactly:

• pio run -e waveshare_rp2040_lora_companion_radio_usb
• dependency graph includes WiFi @ 1.0.0 and BLE @ 0.9.0
• build fails in RP2040 BLE because Bluetooth is not enabled

[JDat]

Why I need BLE support if I don't have BLE chip on my RP2040? My RP2040 just need to work as repeater instead of all this b**it in helpers directory.

Looks like it's time to start discussion regarding PR push quality. #ifdef hacks in platform independent code and do major refactoring to untie meshcore from platforms.

[recrof]

Why I need BLE support if I don't have BLE chip on my RP2040? My RP2040 just need to work as repeater instead of all this b**it in helpers directory.

Looks like it's time to start discussion regarding PR push quality. #ifdef hacks in platform independent code and do major refactoring to untie meshcore from platforms.

Your point is pretty lost on this issue as @robekl correctly identified non-pinned PIO dependency. it's not MeshCore PR that broke the code:

Actual breaking commit: upstream earlephilhower/arduino-pico 6f640bf

[sabraaz]

For whatever it means, I love our "PR push monkeys" and think they do a good job.