Align trace ID and span ID naming with other SDKs

[piotrooo]

What is the expected behavior?
The opentelemetry-php/contrib-auto-psr3 project sets traceId and spanId in camelCase:

https://github.com/opentelemetry-php/contrib-auto-psr3/blob/eebb2559a84e9fd653cbf736c2209f44772c8cc2/src/Psr3Instrumentation.php#L57-L58

What is the actual behavior?
All other SDKs use trace_id and span_id written in snake_case.
Is this intentional, or should it be changed to comply with other SDKs?

_{Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.}

[brettmc]

I think it's ok to change to snake case, if you want to create a PR for it

[bobstrecansky]

@piotrooo are you planning on doing this work, or should we label it help wanted?

[piotrooo]

@piotrooo are you planning on doing this work, or should we label it help wanted?

@bobstrecansky yes, you should label it as help wanted.

[drghdtjr]

Hi @brettmc, @bobstrecansky,

I've analyzed the Psr3Instrumentation.php and confirmed that traceId and spanId are currently using camelCase, which is inconsistent with other SDKs.

I would like to work on this issue. My plan is:

Change the keys from traceId/spanId to trace_id/span_id (snake_case) to align with OTel semantic conventions.

Update the corresponding unit tests in Psr3InstrumentationTest.php.

Could you please assign this issue to me?

src/Instrumentation/Psr3/src/Psr3Instrumentation.php

$params[$ctxIdx]['traceId'] = $span->getTraceId();
$params[$ctxIdx]['spanId'] = $span->getSpanId();

$params[$ctxIdx]['trace_id'] = $span->getTraceId(); 
$params[$ctxIdx]['span_id'] = $span->getSpanId();  

and src/Instrumentation/Psr3/tests/Unit/Psr3InstrumentationTest.php

[drghdtjr]

@brettmc Hi! I've submitted a Pull Request to address this issue.
open-telemetry/opentelemetry-php-contrib#498
Thank you!