Fixes InvalidOperation Exceptions, and other race conditions#581
Open
Toys0125 wants to merge 2 commits intoBasisVR:developerfrom
Open
Fixes InvalidOperation Exceptions, and other race conditions#581Toys0125 wants to merge 2 commits intoBasisVR:developerfrom
Toys0125 wants to merge 2 commits intoBasisVR:developerfrom
Conversation
Contributor
Toys0125
commented
Mar 7, 2026
Toys0125
commented
- Always complete/apply remote face jobs in render callback, even when local player isn’t ready: BasisEventDriver.cs:231, BasisEventDriver.cs:234
- Chain remote face scheduling to prior handle: BasisRemoteFaceManagement.cs:93
- Remote players' face animations should update independently of local player readiness.
- Chain SteamAudio gather jobs to prior frame and complete pending gather jobs before early returns/resizes/dispose: SteamAudioManager.cs:552, SteamAudioManager.cs:580, SteamAudioManager.cs:1016, SteamAudioManager.cs:1032, SteamAudioManager.cs:1055
- Harden uLipSync buffer/job sequencing (complete stale job before reschedule, lock buffer swap/write): BasisUlipSync.cs:55, BasisUlipSync.cs:144, BasisUlipSync.cs:164, BasisUlipSync.cs:451, BasisUlipSync.cs:460
* Always complete/apply remote face jobs in render callback, even when local player isn’t ready: BasisEventDriver.cs:231, BasisEventDriver.cs:234 * Chain remote face scheduling to prior handle: BasisRemoteFaceManagement.cs:93 * Chain SteamAudio gather jobs to prior frame and complete pending gather jobs before early returns/resizes/dispose: SteamAudioManager.cs:552, SteamAudioManager.cs:580, SteamAudioManager.cs:1016, SteamAudioManager.cs:1032, SteamAudioManager.cs:1055 * Harden uLipSync buffer/job sequencing (complete stale job before reschedule, lock buffer swap/write): BasisUlipSync.cs:55, BasisUlipSync.cs:144, BasisUlipSync.cs:164, BasisUlipSync.cs:451, BasisUlipSync.cs:460
Collaborator
|
There is some fundamental we dont need todo it like this, just complete it if its not completed early next frame, does not require all of this pain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.