Fixed decorator image and text in BT basics#59
Open
sprkrd wants to merge 1 commit intoBehaviorTree:masterfrom
Open
Fixed decorator image and text in BT basics#59sprkrd wants to merge 1 commit intoBehaviorTree:masterfrom
sprkrd wants to merge 1 commit intoBehaviorTree:masterfrom
Conversation
👷 Deploy request for adoring-euclid-69d857 pending review.Visit the deploys page to approve it
|
Contributor
|
This logic in your PR seems wrong to me, because if door is open, the sequence fails (it should not fail) |
Author
@facontidavide Of course, it's wrong. But I believe that is exactly the point of the "Find the bug!" text box later. The correct tree would look either like that of Commit 3b8a37c or like this:
But...
|
Author
|
Alternatively, the image after Commit 3b8a37c can be maintained but:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Addresses issues #16 and #58.