Fix inverted isSafeLocation branch logic in backtrack teleport#168
Draft
Fix inverted isSafeLocation branch logic in backtrack teleport#168
Conversation
Merged
The if/else branches were swapped: when isSafeLocation() returned true (safe), the code was teleporting home; when it returned false (unsafe), it placed a block and teleported there. Now: if safe → log + teleport to targetPos; if unsafe → place floor block → re-check → if still unsafe → fall back to home; if now safe → teleport to targetPos. Also adds three targeted tests covering the corrected behaviour. Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from PR #164 on Release 4.8.1
Fix inverted isSafeLocation branch logic in backtrack teleport
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
if/elsebranches inPlayerListener.onPlayerLeaveIslandwere swapped: the safe branch teleported home and the unsafe branch teleported to the ray-traced position.Changes
PlayerListener.java— Correct the condition and restructure the branches:PlayerListenerTest.java— Add three tests covering: safe position teleports directly, always-unsafe falls back to home, and becomes-safe-after-block-placement teleports to target.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.