Open
Conversation
Collaborator
Collaborator
Author
|
Yep I see the 404 error too good catch, looks like its actually a github pages interaction with react router, seems like other people have had this issue though I'll do some research to find a fix |
This reverts commit 1077bde.
This reverts commit cd42aa7.
Collaborator
Author
|
@bdls-jamal @nprovart @VinLau @mwkyuen Ok I think I've fixed the issues with the deployment, required a slightly ugly workaround but it seems like the alternatives aren't much better. Github pages doesn't work quite so well with single page routed apps but this should fix the issue with pasted URLs 404ing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixed issue where staging branch was not successfully deploying to github pages