Conversation
| model_name='bandingtypecurrencyentry', | ||
| index=models.Index(fields=['package', 'banding_type_entry'], name='btce_pkg_bte_idx'), | ||
| ), | ||
| migrations.AddIndex( |
There was a problem hiding this comment.
Unsure how helpful this index will be, as the bandingtypeentry is probably shared by many rows
| else: | ||
| self.helper.layout.append( | ||
| Layout( | ||
| HTML( |
There was a problem hiding this comment.
Somewhat curious offloading the HTML generation into this routine, rather than using a template?
| return prices | ||
|
|
||
| @functools.cached_property | ||
| def fast_price_bandings(self) -> dict: |
There was a problem hiding this comment.
This looks OK, but I really would like it to have a debug/logging mode where it writes output about what it is doing to the price debugger. Could just add an optional parameter to the function debug=False that when true then returns a tuple of (prices, debug_string). This way we could easily hook it up to the debugger? I am just worried that, although it all looks fine at this point, we might hit an edge case with OBC where we can't work out what it's doing and need to debug the logic.
There was a problem hiding this comment.
Hmm. This might be the wrong place for this comment. I can see that other functions still have the "explain" bool signature, below, so perhaps the debugger is still in tact
| def _compare(self, package): | ||
| original = package.price_bandings | ||
|
|
||
| if "fast_price_bandings" in package.__dict__: |
There was a problem hiding this comment.
I think this code is forcing a cached property to reload, but it's hard to understand. It looks like the code deletes an instance attribute but then accesses it immediately...
2 participants
No description provided.