Add variance formula for Kaplan Meier estimator#678
Add variance formula for Kaplan Meier estimator#678syadlowsky wants to merge 2 commits intoCamDavidsonPilon:masterfrom
Conversation
|
👋 hello @syadlowsky! Thanks for the contribution - can you expand on why you would like to see this added? |
|
I'm working on a project where, to do inference, we need to be able to estimate the variance of the Kaplan-Meier estimator. It looks like right now, you only have the confidence intervals, but exposing the variance estimator itself might be useful for others' downstream applications, as well. |
|
Just wanted to bring this up again. |
|
Sorry about the delay! So overall I like this PR, but I want to keep the variance's computed here the same as the variances computed in the CIs. That is, I feel this should be using the exponential form of greenwood's variance. (eq 1.3 in the notes in the docstring). What do you think? |
|
Somehow, I didn't see the reply. Sorry about that. The issue with the exponential form of the variance is that it gives a variance for log(S(t)), whereas I need (and one might expect a variance function to give) the variance for S(t). One alternative is to add both, adding the exponential form as variance_log_survival_. At least this gives something clear for people to think about when choosing which they want, and would possibly allow some code reuse with the confidence interval estimates. Plus it would give something to point to if someone asks why variance_ doesn't line up with confidence intervals. Does this seem like reasonable recourse? If so, I can fix this and try to deal with the merge conflict that has come up in the meantime. |
2 participants
No description provided.