Open
Conversation
devinmatte
approved these changes
Dec 25, 2020
Member
devinmatte
left a comment
devinmatte
left a comment
There was a problem hiding this comment.
I'd be fine to get this merged, but do plan to replace travis with GitHub CI not long after
Contributor
Author
|
I'd say hold off merging, pylint and mypy haven't been run in a long time, so checks will fail on every pr until we make a concerted effort to fix it. Do please bump psycopg2 so it's runnable with recent python. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up travis to run pylint and mypy tests.
This PR doesn't fix the current issues, just sets up the ci to make them visible.