Release: merge development into beta#1
Open
github-actions[bot] wants to merge 43 commits intobetafrom
Open
Conversation
Add unstable release, dev-to-beta PR creation, branch protection check, and lint check workflows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enforce that PRs to main can only come from beta or hotfix branches, and PRs to beta can only come from development or hotfix branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Add Rijkshuisstijl header styling to MyDash app - Create header-override.css for white header with blue logo bar - Override nldesign theme CSS with maximum specificity selectors - Add Nederland logo in blue bar (matching login page design) - Load override CSS in Application.php boot() method - Header is now white with dark icons/text for better contrast * Update blue bar to stick out above header with Nederland logo - Blue bar now extends 50px above header (top: -50px) - Bar height increased to 100px for proper visibility - Nederland logo copied to mydash/img/ folder for accessibility - Logo positioned at bottom of blue bar (bottom: 5px) - Logo uses relative path from CSS folder (../img/nederland-logo.svg) - Body overflow set to visible to allow bar to extend above page - Header overflow set to visible for pseudo-elements * Fix header text and icons to be dark/blue on white background - Remove filter: invert(1) from icons (was making them white) - Set all header text to dark gray (#333333) - Set app name and header links to Rijksblauw (#154273) - App menu active/hover states use blue (#154273) with bold text - Unified search icon and SVGs set to dark (#333333) - User menu, notifications, contacts icons set to dark (opacity: 0.8) - Settings menu icon filter removed for proper dark display - All icons and text now properly visible on white header background * Replace pseudo-element approach with fixed positioning for blue logo bar BREAKING CHANGE: Switch from CSS ::before/::after to real DOM element positioning - Use position: fixed on header-appname-container/dashboard link - Blue bar now targets actual logo element instead of pseudo-elements - Logo displays at bottom of bar with flexbox (align-items: flex-end) - Z-index: 9999 ensures bar floats above all content - Logo made white via filter: brightness(0) invert(1) - Works with both <img> and <svg> logo elements - Bar dimensions: 60px wide × 100px tall, positioned at top: 0, left: 5px - Remove old ::before and ::after pseudo-element code - Logo now properly visible at bottom of blue bar across all pages * Update selectors to target correct DOM structure (a#nextcloud) - Target actual Nextcloud logo link: a#nextcloud and a[href="/"] - Also target .header-start wrapper (in addition to .header-left) - Logo div (.logo) background replaced with nederland-logo.svg - Remove incorrect selectors (.header-appname-container, dashboard link) - Add legacy support for img/svg elements inside logo link - Box-sizing: border-box for proper padding calculation - Logo positioned at bottom via flexbox (align-items: flex-end) - Fixed positioning ensures logo bar floats above all content * Fix white space at top and logo positioning at bottom of blue bar - Remove margin-top and padding-top from html, body, and #body-user - Eliminates white space above blue bar - Change flexbox to flex-direction: column with justify-content: flex-end - Logo now correctly positioned at bottom of blue bar - Adjust padding: remove all padding except padding-bottom: 10px - Logo displays at bottom with proper spacing from edge * Center logo in blue bar with margin: 0 auto and flex-shrink: 0 * Adjust blue bar dimensions and positioning - Height reduced from 100px to 60px for more compact look - Left position changed from 5px to 15px - margin-top: 0px !important to override Nextcloud header.scss - margin-left: 0px !important for precise positioning - Logo height adjusted to 30px to fit 60px bar * Increase blue bar height to 80px and adjust logo size - Height changed from 60px to 80px for better visual balance - Logo height adjusted to 32px to fit proportionally * Add aggressive overrides to center and show logo properly - visibility: visible !important (was hidden) - padding: 0 !important (remove 70px left padding) - text-indent: 0 !important (was -9999px) - min-height and max-height: 32px (override 50px) - text-align: center for proper centering - Logo now properly visible and centered in blue bar * More fixes on mydash * Add ESLint configuration and fix linting errors - Add eslint.config.js with Nextcloud ESLint config - Add required ESLint dependencies - Fix indentation and trailing spaces - All linting checks now pass * Trying to figure out why the widgets stopt loading * fix: resolve lint errors in WidgetRenderer - Merge duplicate pinia imports into single import statement - Remove unused NcDashboardWidgetItem component registration - Fix indentation of widgetItems computed property (1 tab too few) - Remove trailing whitespace Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add /js/ to gitignore and remove tracked build artifacts Build output should not be committed to the repository. Simplified gitignore to ignore the entire /js/ directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
- Create header-override.css for white header with blue logo bar - Override nldesign theme CSS with maximum specificity selectors - Add Nederland logo in blue bar (matching login page design) - Load override CSS in Application.php boot() method - Header is now white with dark icons/text for better contrast
- Blue bar now extends 50px above header (top: -50px) - Bar height increased to 100px for proper visibility - Nederland logo copied to mydash/img/ folder for accessibility - Logo positioned at bottom of blue bar (bottom: 5px) - Logo uses relative path from CSS folder (../img/nederland-logo.svg) - Body overflow set to visible to allow bar to extend above page - Header overflow set to visible for pseudo-elements
- Remove filter: invert(1) from icons (was making them white) - Set all header text to dark gray (#333333) - Set app name and header links to Rijksblauw (#154273) - App menu active/hover states use blue (#154273) with bold text - Unified search icon and SVGs set to dark (#333333) - User menu, notifications, contacts icons set to dark (opacity: 0.8) - Settings menu icon filter removed for proper dark display - All icons and text now properly visible on white header background
BREAKING CHANGE: Switch from CSS ::before/::after to real DOM element positioning - Use position: fixed on header-appname-container/dashboard link - Blue bar now targets actual logo element instead of pseudo-elements - Logo displays at bottom of bar with flexbox (align-items: flex-end) - Z-index: 9999 ensures bar floats above all content - Logo made white via filter: brightness(0) invert(1) - Works with both <img> and <svg> logo elements - Bar dimensions: 60px wide × 100px tall, positioned at top: 0, left: 5px - Remove old ::before and ::after pseudo-element code - Logo now properly visible at bottom of blue bar across all pages
- Target actual Nextcloud logo link: a#nextcloud and a[href="/"] - Also target .header-start wrapper (in addition to .header-left) - Logo div (.logo) background replaced with nederland-logo.svg - Remove incorrect selectors (.header-appname-container, dashboard link) - Add legacy support for img/svg elements inside logo link - Box-sizing: border-box for proper padding calculation - Logo positioned at bottom via flexbox (align-items: flex-end) - Fixed positioning ensures logo bar floats above all content
- Remove margin-top and padding-top from html, body, and #body-user - Eliminates white space above blue bar - Change flexbox to flex-direction: column with justify-content: flex-end - Logo now correctly positioned at bottom of blue bar - Adjust padding: remove all padding except padding-bottom: 10px - Logo displays at bottom with proper spacing from edge
- Height reduced from 100px to 60px for more compact look - Left position changed from 5px to 15px - margin-top: 0px !important to override Nextcloud header.scss - margin-left: 0px !important for precise positioning - Logo height adjusted to 30px to fit 60px bar
- Height changed from 60px to 80px for better visual balance - Logo height adjusted to 32px to fit proportionally
- visibility: visible !important (was hidden) - padding: 0 !important (remove 70px left padding) - text-indent: 0 !important (was -9999px) - min-height and max-height: 32px (override 50px) - text-align: center for proper centering - Logo now properly visible and centered in blue bar
- Add eslint.config.js with Nextcloud ESLint config - Add required ESLint dependencies - Fix indentation and trailing spaces - All linting checks now pass
- Merge duplicate pinia imports into single import statement - Remove unused NcDashboardWidgetItem component registration - Fix indentation of widgetItems computed property (1 tab too few) - Remove trailing whitespace Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace existing license (Apache-2.0/AGPL) with EUPL-1.2 across all metadata files: LICENSE, appinfo/info.xml, composer.json, package.json. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tylelint) Add Conduction coding standard with custom sniffs, PHPMD mess detection, phpmetrics code metrics, and stylelint for CSS linting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add PR checks for PHP quality (PHPCS, PHPMD, phpmetrics) and frontend quality (ESLint, stylelint) that run on pull requests to main branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply Conduction PHPCS standard to all Db entities and mappers. Add concrete utility classes and interfaces to Db namespace to fix SAP violation. Split monolithic migration into dedicated table builders. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…mplexity Extract WidgetFormatter, WidgetItemLoader, PlacementService, PlacementUpdater, TileUpdater, VisibilityChecker, UserAttributeResolver, DashboardFactory, DashboardResolver, TemplateService, AdminSettingsService, AdminTemplateService, RuleEvaluatorService, ResponseHelper, and RequestDataExtractor. Add dedicated RuleApiController. Reduces phpmetrics violations to zero. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Only allow PRs from 'development' or 'hotfix/*' branches to merge into main. Other source branches will be blocked by a required status check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enforce branching strategy: main only from beta, beta only from development, development only from feature/*. Hotfix/* bypasses all restrictions. Add beta to quality check triggers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document the promotion-based branching model (feature→development→beta→main), hotfix policy, required quality checks, and local development workflow with a mermaid flow diagram. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rary Replace NcSettingsSection with CnSettingsSection from @conduction/nextcloud-vue. Add webpack alias for shared library with dedup aliases (vue$, pinia$, @nextcloud/vue$) to prevent dual-instance bugs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…webpack alias Makes the shared library work in both monorepo dev (local source alias) and CI/production builds (npm package from git). The alias only activates when ../nextcloud-vue/src exists. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replaces github:ConductionNL/nextcloud-vue#main with ^0.1.0-beta.1 from npm registry. Faster installs, no git clone + build step. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix systemic snake_case to camelCase field names across all 8 specs - Fix dashboards: correct isActive default, missing fields, response format - Fix widgets: correct coordinate names (gridX/gridY), visibility model - Fix tiles: correct storage model (inline on placements), add missing fields - Fix admin-settings: correct default permission level, API parameter names - Fix conditional-visibility: correct rule logic (include=OR, exclude=AND) - Fix grid-layout: correct min size (2x2), note missing debounce - Fix permissions: add dynamic permission resolution notes - Fix admin-templates: correct single-template distribution model - Add status: reviewed frontmatter to all 8 specs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Nextcloud App Store schema does not accept EUPL-1.2 as a valid licence value, causing all release uploads to fail with HTTP 400. Revert to 'agpl' which is in the accepted set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace psalm/phar with vimeo/psalm ^5.26 - Add phpstan/phpstan ^1.10 + phpstan.neon config - Add nextcloud/coding-standard, phpcsstandards/phpcsextra - Add roave/security-advisories, edgedesign/phpqa - Create psalm.xml with Nextcloud OCP suppressions - Add phpstan, phpmetrics:violations, phpcs:output, phpqa scripts - Fix phpmetrics:violations flag to --violations-xml (matching OpenRegister) - Update nextcloud/ocp to ^31.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add code-quality CI workflow and apply coding standard fixes to PHP files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: PHPCS coding standard fixes and quality tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to sync development changes to beta for beta release.
Merging this PR will trigger the beta release workflow.