Release: merge development into beta#1
Open
github-actions[bot] wants to merge 43 commits intobetafrom
Open
Conversation
Add unstable release, dev-to-beta PR creation, branch protection check, and lint check workflows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enforce that PRs to main can only come from beta or hotfix branches, and PRs to beta can only come from development or hotfix branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add file-level docblocks with license URL to all PHP classes - Add complete method docblocks with @param and @return tags - Fix @AuthorizedAdminSetting annotation placement (after @param tags) - Fix indentation and spacing to match Nextcloud coding standards - All PHPCS errors resolved (exit code 0)
- Toggle between icons and text labels in app menu - Center text labels vertically and horizontally - Remove Nextcloud default active indicator - Clean up CSS specificity - Version bump to 0.1.1-unstable.3
- Add npm run lint script that explains nldesign is CSS/PHP only - This allows CI/CD pipelines to pass linting checks
- Update build-fonts.js to copy actual font files from node_modules - Remove webpack aliases (@import url('~@fontsource...')) from fonts.css - Use relative paths to local font files (fonts/fira-sans-*.woff2) - Bump version to 0.1.1-unstable.4 to invalidate cache - Fixes MIME type errors and 404s for font files
* Fixing the login page * Fix PHP coding standards and add complete docblocks - Add file-level docblocks with license URL to all PHP classes - Add complete method docblocks with @param and @return tags - Fix @AuthorizedAdminSetting annotation placement (after @param tags) - Fix indentation and spacing to match Nextcloud coding standards - All PHPCS errors resolved (exit code 0) * Mere wrok in the internal pages of nextcloud * Code cleanup * Ading icon less menu's * Add show menu labels feature - Toggle between icons and text labels in app menu - Center text labels vertically and horizontally - Remove Nextcloud default active indicator - Clean up CSS specificity - Version bump to 0.1.1-unstable.3 * Let get the navigation in line * Supprting mydash * Add lint script to package.json - Add npm run lint script that explains nldesign is CSS/PHP only - This allows CI/CD pipelines to pass linting checks * Fix font loading by using local font files - Update build-fonts.js to copy actual font files from node_modules - Remove webpack aliases (@import url('~@fontsource...')) from fonts.css - Use relative paths to local font files (fonts/fira-sans-*.woff2) - Bump version to 0.1.1-unstable.4 to invalidate cache - Fixes MIME type errors and 404s for font files * Remove bad file * Adding some more overwrites
And clearing up the docs
Replace self-referencing fallback values (e.g. var(--foo, var(--foo))) with concrete fallback values from defaults.css. Self-referencing CSS custom properties create cycles that result in the guaranteed-invalid value, causing components to lose their styling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace custom --nldesign-color-page-background with Nextcloud's --color-background-plain for page background color - Use --nldesign-border-radius variable for login form corners - Remove unused page-background tokens from defaults and rijkshuisstijl Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add exclusion selectors for .button-vue--vue-primary span and div elements so the NL Design text color override does not affect primary button labels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bump version from 0.1.1-unstable.4 to 0.1.1-unstable.14 - Simplify Rijkshuisstijl SVG logo - Add Rijksoverheid favicon - Update brand-identity docs and token-sets config - Update build scripts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace existing license (Apache-2.0/AGPL) with EUPL-1.2 across all metadata files: LICENSE, appinfo/info.xml, composer.json, package.json. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tylelint) Add Conduction coding standard with custom sniffs, PHPMD mess detection, phpmetrics code metrics, and stylelint for CSS linting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add PR checks for PHP quality (PHPCS, PHPMD, phpmetrics) and CSS quality (stylelint) that run on pull requests to main branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply Conduction PHPCS standard to all PHP files. Extract ThemingService from SettingsController to handle color/image validation and application, reducing controller complexity and fixing phpmetrics violations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Only allow PRs from 'development' or 'hotfix/*' branches to merge into main. Other source branches will be blocked by a required status check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enforce branching strategy: main only from beta, beta only from development, development only from feature/*. Hotfix/* bypasses all restrictions. Add beta to quality check triggers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document the promotion-based branching model (feature→development→beta→main), hotfix policy, required quality checks, and local development workflow with a mermaid flow diagram. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add openspec/config.yaml with NL Design project context - Add reviewed specs for 6 feature areas: theming-sync, menu-labels, hide-slogan, admin-settings, token-sets, css-architecture - Fix URL prefixes, annotation parameters, missing docs link, XSS prevention description, token set count, CSS layer descriptions - All specs include status: reviewed frontmatter Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Nextcloud App Store schema does not accept EUPL-1.2 as a valid licence value, causing all release uploads to fail with HTTP 400. Revert to 'agpl' which is in the accepted set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add vimeo/psalm ^5.26 + psalm.xml config - Add phpstan/phpstan ^1.10 + phpstan.neon config - Add nextcloud/coding-standard, phpcsstandards/phpcsextra - Add phpunit/phpunit ^10.5, roave/security-advisories, edgedesign/phpqa - Add psalm, phpstan, phpmetrics:violations, phpcs:output, phpqa scripts - Fix phpmetrics:violations flag to --violations-xml (matching OpenRegister) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…and reference sections - Reorganize docs/ into getting-started/, features/, and reference/ subdirectories - Move all 8 existing technical docs to docs/reference/ with sidebar_position frontmatter - Add docs/intro.md as landing page with slug: / - Add docs/getting-started/ (installation.md, configuration.md) - Add docs/features/ (token-sets.md, css-architecture.md, theming-sync.md, admin-settings.md, toggles.md, app-compatibility.md) - Update Docusaurus homepage: 6 feature cards, CTA links to /docs - Update footer and config links to point to /docs - Add _category_.json files for Getting Started (pos 1), Features (pos 2), Reference (pos 3) - Archive enhance-docs-website change, sync docs-content spec to main specs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…p images Adds an 8th CSS layer (custom-overrides) that loads admin-defined token overrides last so they always win over the bundled token sets. Introduces CustomOverridesService, TokenRegistry, and TokenSetPreviewService. Updates admin settings controller and template to expose the new overrides and preview endpoints. Adds app icon, app-store image, and admin/login screenshots. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add code-quality CI workflow, update config, and apply coding standard fixes to PHP and JS files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…leanup # Conflicts: # QUICKSTART.md # README.md # appinfo/info.xml # appinfo/routes.php # composer.lock # css/admin.css # css/overrides.css # css/theme.css # css/tokens/amsterdam.css # css/tokens/rijkshuisstijl.css # css/tokens/utrecht.css # js/admin.js # lib/AppInfo/Application.php # lib/Controller/SettingsController.php # lib/Settings/Admin.php # package.json
fix: PHPCS coding standard fixes and quality tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to sync development changes to beta for beta release.
Merging this PR will trigger the beta release workflow.