Various fixes/missing fields#24
Open
florian1345 wants to merge 2 commits intoConsenSysDiligence:masterfrom
Open
Various fixes/missing fields#24florian1345 wants to merge 2 commits intoConsenSysDiligence:masterfrom
florian1345 wants to merge 2 commits intoConsenSysDiligence:masterfrom
Conversation
- Added `name` field to `TypeDefinition` nodes
- Added `isVirtual` and `isOverride` fields to `ModifierDefinition` nodes
- Added support for parsing for `FunctionCallOptions` (of the form `fn{key=value}(args)`)
- Added support for parsing `IndexRangeAccess`es (of the form `array[from:to]`)
- Fixed parser discarding all variable declarations in a variable declaration list if one is `None`
- Fixed parser failing if an assembly member's identifier is a list
- Fixed parser failing an assembly assignment to a member
- Added proper nodes for the `ReturnStatement`, `BreakStatement`, and `ContinueStatement`
|
|
- Added "isDeclaredImmutable" to variable declaration, similar to "isDeclaredConst" - Rendered omitted loop expressions in for loops as None instead of an ExpressionStatement with None as its expression - Added storageLocation field to variable declarations inside a variable declaration list
|
Would that be okay to review and merge this PR @tintinweb ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just an informal collection of problems I encountered and fixed locally.
Sorry for not presenting it in a more organized way.
Feel free to modify/integrate it however you like.
namefield toTypeDefinitionnodesisVirtualandisOverridefields toModifierDefinitionnodesFunctionCallOptions(of the formfn{key=value}(args))IndexRangeAccesses (of the formarray[from:to])ReturnStatement,BreakStatement, andContinueStatement(which were previously rendered as the return expression or just';'for expression-less statements)NoneI added some more fixes with commit eb548d1 on 2022-05-12:
isDeclaredImmutableto variable declaration, similar toisDeclaredConstNoneinstead of anExpressionStatementwithNoneas its expressionstorageLocationfield to variable declarations inside a variable declaration list