Skip to content

Add entity_id check to the get_target function in gui/rename #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ab9rf merged 2 commits into from
Feb 10, 2026
Merged

Add entity_id check to the get_target function in gui/rename #1552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d146c3c
Added entity_id check to get_target function
Kyrozis Jan 28, 2026
c31f399
Added change description to changelog.txt
Kyrozis Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Template for new versions:
## New Features

## Fixes
- `gui/rename`: added check for entity_id input in get_target function

## Misc Improvements

Expand Down
3 changes: 3 additions & 0 deletions gui/rename.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,9 @@ local function get_target(opts)
if opts.histfig_id then
target = get_hf_target(df.historical_figure.find(opts.histfig_id))
if not target then qerror('Historical figure not found') end
elseif opts.entity_id then
target = get_entity_target(df.historical_entity.find(opts.entity_id))
if not target then qerror('Entity not found') end
elseif opts.item_id then
target = get_artifact_target(df.item.find(opts.item_id))
if not target then qerror('Artifact not found') end
Expand Down