Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populates the parentAutoProcProgramId column of the AutoProcProgram ISPyB table when registering processing to enable easier tracing of upstream pipelines.
Replaces the stored program call used for registerring processing with a more direct call to the ispyb-api. This is to avoid updating the stored program in the ispyb-api as the ispyb team are moving away from using stored programs. Only the register_processing function has been edited as parentAutoProcProgramId will only need to be populated at the start of processing. Function is provided the scaling_id from the parent AutoProcProgram and obtains the corresponding parent autoProcProgramId from the database.
The scaling_id can be provided to the ispyb service either in the environment dictionary (which is typically populated with {ispyb_reprocessing_parameters}) or from an explicitly named parameter in the service call.
Updates the ispyb api dependency tp 11.1.2 to pick up the schema changes that include the new parentAutoProcProgramId column.