Move import options into import private key scene#5982
Merged
Conversation
Contributor
Author
Contributor
j0ntz
approved these changes
Mar 23, 2026
j0ntz
approved these changes
Mar 23, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Stale eslint config entry for deleted file
- Removed the obsolete
CreateWalletImportOptionsScene.tsxentry fromeslint.config.mjsafter confirming the file no longer exists.
- Removed the obsolete
Or push these changes by commenting:
@cursor push ac1b4d2d86
Preview (ac1b4d2d86)
diff --git a/eslint.config.mjs b/eslint.config.mjs
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -242,8 +242,6 @@
'src/components/scenes/CreateWalletAccountSetupScene.tsx',
'src/components/scenes/CreateWalletCompletionScene.tsx',
- 'src/components/scenes/CreateWalletImportOptionsScene.tsx',
-
'src/components/scenes/CurrencyNotificationScene.tsx',
'src/components/scenes/DefaultFiatSettingScene.tsx',
'src/components/scenes/DuressModeHowToScene.tsx',This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Resolves the warning Require cycle: src/plugins/stake-plugins/uniswapV2/policyInfo/fantom.ts -> src/plugins/stake-plugins/uniswapV2/policyInfo/fantom.ts Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
28bb77b to
6e033f7
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




The current import key scene calls
importKeywithout any options as a test. This isn't ideal for plugins that do import options validations in that function. Some plugins fake it or have workarounds for missing options.Included are some unrelated fixes for warnings seen while debugging.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Changes the wallet import flow to collect and pass per-plugin
keyOptionsintoimportKeyand wallet creation, which could affect key/seed import behavior across currencies. Also includes low-risk refactors in staking plugins and state selectors that may surface edge-case runtime issues if assumptions differ.Overview
Wallet import flow consolidation: removes
CreateWalletImportOptionsSceneand thecreateWalletImportOptionsroute, moving per-pluginimportKeyOptionscollection/validation directly intoCreateWalletImportScene. The import screen now renders editable option rows (with required/validation states), disables Next until the import text and required options are valid, and passes computedkeyOptionsinto both theimportKeytest call andcreateWalletCompletionwallet creation.Staking cleanup/fixes: introduces a frozen
EMPTY_STAKE_POSITION_MAPto avoid creating new fallback objects on each render, and refactors Fantom UniswapV2 staking policy ecosystem setup into a newfantomEcosystem.tsmodule to break cyclical imports. Includes small type-safety tweaks in UniswapV2 policies and updates the import-scene snapshot accordingly.Written by Cursor Bugbot for commit 6e033f7. This will update automatically on new commits. Configure here.