Preserve any passkeys in onyx when clearing the cache or logging out#86059
Preserve any passkeys in onyx when clearing the cache or logging out#86059rafecolton wants to merge 3 commits intomainfrom
Conversation
dariusz-biela
left a comment
There was a problem hiding this comment.
The code looks good.
I checked it, and it covers all cases where onyx is cleared that weren't previously handled by KEYS_TO_PRESERVE.
I'm waiting for the merge PR with the manual tests [HOLD react-native-onyx#759]
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb14a626cc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Looks like some kind of state issue in the case where the user signs out, then immediately signs back in, without refreshing the page. Registration gets stuck on the soft prompt. Perhaps we need to preserve macos chromeapp.pr.first.run.after.login.gets.stuck.mp4 |
|
Hmm, I am getting the same error 🤔 |
Hold for Expensify/react-native-onyx#759
Explanation of Change
Preserve passkey credential IDs when clearing Onyx cache. This matches the behavior of mobile native keys, which are similarly preserved through logout. The values are verified server-side and attached to an accountID, so there is no risk in storing them or in them being accessed by another account. This alleviates the need for frequent re-registration on the same browser.
cc @chuckdries @dariusz-biela
Fixed Issues
$ #86005
PROPOSAL: N/A
Tests
Testflow in the Troubleshoot menu on webTestbutton prompts for authentication only once (i.e. authenticate flow, not registration flow)Offline tests
N/A, online only
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-03-22.at.2.14.23.PM.mov