Open
Conversation
Collaborator
jennyhougen
commented
Mar 8, 2026
jennyhougen
commented
- Project for validating Jwt DPoP tokens
bvst
reviewed
Mar 9, 2026
bvst
reviewed
Mar 9, 2026
bvst
reviewed
Mar 9, 2026
bvst
reviewed
Mar 9, 2026
bvst
reviewed
Mar 9, 2026
src/Fhi.Authentication.JwtDPoP/Configurations/JwtDpopOptions.cs
Outdated
Show resolved
Hide resolved
bvst
reviewed
Mar 9, 2026
src/Fhi.Authentication.JwtDPoP/Validation/DPoPProofCompositeValidator.cs
Outdated
Show resolved
Hide resolved
bvst
reviewed
Mar 9, 2026
src/Fhi.Authentication.JwtDPoP/Configurations/DPoPProofTokenValidationParameters.cs
Outdated
Show resolved
Hide resolved
bvst
reviewed
Mar 9, 2026
src/Fhi.Authentication.JwtDPoP/Configurations/DPoPProofTokenValidationParameters.cs
Show resolved
Hide resolved
bvst
reviewed
Mar 9, 2026
bvst
reviewed
Mar 9, 2026
src/Fhi.Authentication.JwtDPoP/Validation/Models/DpopValidationResult.cs
Outdated
Show resolved
Hide resolved
bvst
reviewed
Mar 9, 2026
src/Fhi.Authentication.JwtDPoP/Validation/DPoPProofValidators/IDPoPProofValidators.cs
Outdated
Show resolved
Hide resolved
bvst
reviewed
Mar 9, 2026
| { | ||
| internal interface IDPoPProofValidators | ||
| { | ||
| Task<DpopValidationResult> ExecuteAsync(DPoPValidationContext context, JsonWebToken? proofToken, CancellationToken cancellationToken = default); |
Contributor
There was a problem hiding this comment.
De som bruker proofToken sier at verdien ikke er null (!proofToken). Endre kontrakten til å være JsonWebToken proofToken
Collaborator
Author
There was a problem hiding this comment.
Skjønte ikke kommentaren?
Contributor
There was a problem hiding this comment.
Fra hva jeg kan se så er aldri proofToken null.
Når den blir implementert så sier man proofToken!. Så kanskje endre kontrakten?
Collaborator
Author
There was a problem hiding this comment.
Ah.. så ikke !. Den er fyfy i prod kode. Jeg skal endre kontrakten og gjøre null sjekken på utsiden. token kan være null. Godt vi har codereview :)
bvst
reviewed
Mar 9, 2026
src/Fhi.Authentication.JwtDPoP/Validation/DPoPProofValidators/JtiReplayValidator.cs
Outdated
Show resolved
Hide resolved
Kattemat
approved these changes
Mar 10, 2026
Contributor
Kattemat
left a comment
Kattemat
left a comment
There was a problem hiding this comment.
ser greit ut det jeg forstod så langt !
bvst
reviewed
Mar 10, 2026
|
|
||
| internal static partial class DPoPConstants | ||
| { | ||
| internal static class ItemPorpertyName |
Contributor
There was a problem hiding this comment.
typo: ItemPorpertyName → ItemPropertyName
bvst
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.