fix: 'save' icon indication bug#294
Open
RealCodeFixes wants to merge 2 commits intoFossifyOrg:mainfrom
Open
Conversation
The save button's visibility is now conditional on there being actual unsaved changes in any of the open notes. This prevents the button from being displayed unnecessarily when autosave is disabled but no modifications have been made.
naveensingh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
Before & after preview
after.mp4
before.mp4
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).I also noticed that even after my changes when you don't save a note and change to another one the icon stays visible I would try to fix it but unfortunately I won't have enough free time to fix it now