feat: support new field server_certificate_rotation_mode for SQL inst…

[wuchris-g]

sql: added `server_certificate_rotation_mode` field to `google_sql_database_instance` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[wuchris-g]

Hi @NickElliot, could you take a look? And also approve the tests to run on this PR?

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 79 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 79 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (234 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    ip_configuration {
      enable_private_path_for_google_cloud_services = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [settings.ip_configuration.server_certificate_rotation_mode]

[modular-magician]

Tests analytics

Total tests: 144
Passed tests: 66
Skipped tests: 27
Affected tests: 51

Click here to see the affected service packages

• sql

Action taken

Found 51 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig
• TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig
• TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithDiskSize
• TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithoutDiskSize
• TestAccSqlDatabaseInstance_Edition_Downgrade
• TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration
• TestAccSqlDatabaseInstance_EnableGoogleMlIntegration
• TestAccSqlDatabaseInstance_FinalBackupConfig
• TestAccSqlDatabaseInstance_MysqlEplusWithFailoverReplicaSetupWithPrivateNetwork
• TestAccSqlDatabaseInstance_MysqlReadPoolAutoScaleEnableDisableSuccess
• TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess
• TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess
• TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade
• TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled
• TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer
• TestAccSqlDatabaseInstance_PostgresEplusWithFailoverReplicaSetupWithPrivateNetwork
• TestAccSqlDatabaseInstance_PostgresReadPoolAutoScaleChangeNodeCount
• TestAccSqlDatabaseInstance_PostgresReadPoolScaleOutSuccess
• TestAccSqlDatabaseInstance_PostgresReadPoolScaleUpSuccess
• TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess
• TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade
• TestAccSqlDatabaseInstance_RetainBackupOnDelete
• TestAccSqlDatabaseInstance_Smt
• TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate
• TestAccSqlDatabaseInstance_SwitchoverSuccess
• TestAccSqlDatabaseInstance_authNets
• TestAccSqlDatabaseInstance_basicMSSQL
• TestAccSqlDatabaseInstance_basicMSSQL_passwordWo
• TestAccSqlDatabaseInstance_basic_with_user_labels
• TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls
• TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance
• TestAccSqlDatabaseInstance_hyperdisk
• TestAccSqlDatabaseInstance_majorVersionUpgradeForEnhancedBackupTierInstance
• TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable
• TestAccSqlDatabaseInstance_setServerCertRotationMode
• TestAccSqlDatabaseInstance_settings_deletionProtection
• TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled
• TestAccSqlDatabaseInstance_settings_upgrade
• TestAccSqlDatabaseInstance_updateInstanceTierForEnhancedBackupTierInstance
• TestAccSqlDatabaseInstance_updateMCPEnabled
• TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled
• TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL
• TestAccSqlDatabaseInstance_useCasBasedServerCa
• TestAccSqlDatabaseInstance_useCustomSubjectAlternateName
• TestAccSqlDatabaseInstance_useCustomerManagedServerCa
• TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject
• TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections
• TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange
• TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange
• TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment
• TestAccSqlDatabase_instanceWithActivationPolicy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithDiskSize [Debug log]
TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithoutDiskSize [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_FinalBackupConfig [Debug log]
TestAccSqlDatabaseInstance_MysqlEplusWithFailoverReplicaSetupWithPrivateNetwork [Debug log]
TestAccSqlDatabaseInstance_MysqlReadPoolAutoScaleEnableDisableSuccess [Debug log]
TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresEplusWithFailoverReplicaSetupWithPrivateNetwork [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolAutoScaleChangeNodeCount [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolScaleOutSuccess [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolScaleUpSuccess [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_RetainBackupOnDelete [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL_passwordWo [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_hyperdisk [Debug log]
TestAccSqlDatabaseInstance_majorVersionUpgradeForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_setServerCertRotationMode [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_updateInstanceTierForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_updateMCPEnabled [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_useCustomSubjectAlternateName [Debug log]
TestAccSqlDatabaseInstance_useCustomerManagedServerCa [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_useCasBasedServerCa [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 79 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 79 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (234 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    ip_configuration {
      enable_private_path_for_google_cloud_services = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [settings.ip_configuration.server_certificate_rotation_mode]

[modular-magician]

Tests analytics

Total tests: 144
Passed tests: 117
Skipped tests: 27
Affected tests: 0

Click here to see the affected service packages

• sql

🟢 All tests passed!

View the build log

[NickElliot]

LGTM!

[shuyama1]

@wuchris-g Some SQL tests failed in last night's test runs due to Error 400: Invalid request: Server certificate rotation during maintenance is not supported yet.., invalid. Is this feature not ready yet?

[shuyama1]

Seeing the same error last night. Reverting the change for now.