Add prefix validation to ipv4 and ipv6 filter#624
Open
Nimok wants to merge 1 commit intoHubSpot:masterfrom
Open
Add prefix validation to ipv4 and ipv6 filter#624Nimok wants to merge 1 commit intoHubSpot:masterfrom
Nimok wants to merge 1 commit intoHubSpot:masterfrom
Conversation
Nimok
force-pushed
the
Add-prefix-validation-to-ipv4-and-ipv6
branch
from
0143716 to
ea8814f
Compare
Author
|
@jasmith-hs Has anyone taken a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In jinja2 the ipv4 and ipv6 filters return true on ip address containing valid prefixes.
Jinjava currently returns false in these cases since no pattern-matching is done on prefixes.
Jinja2 also supports leading zeroes in both ipv4 address and prefix.
This patch fixes both of these issues.
Examples of valid addresses: 192.168.0.1/24 and 1200:0000:AB00:1235:0000:2552:7777:1313/128