Remove LLVM 20 limitation#485
Remove LLVM 20 limitation#485MathewBensonCode wants to merge 1 commit intoJeanPhilippeKernel:developfrom
Conversation
| if ($IsLinux) { | ||
| '/usr/bin/clang-format' | ||
| '/usr/bin/clang-format-21' | ||
| '/usr/bin/clang-format-20' |
There was a problem hiding this comment.
That means we want to remove the clang-format-20 from candidate list
There was a problem hiding this comment.
I thought to leave it in as a precaution incase someone is still on the older platform. The main idea was to remove the restriction on newer versions but that compatibility with the older version is retained as specified in repoConfig.json
MathewBensonCode
force-pushed
the
update-llvm
branch
from
fa70173 to
3e0a9fc
Compare
MathewBensonCode
force-pushed
the
update-llvm
branch
from
3e0a9fc to
8ad3db9
Compare
MathewBensonCode
force-pushed
the
update-llvm
branch
from
8ad3db9 to
2582656
Compare
MathewBensonCode
force-pushed
the
update-llvm
branch
from
2582656 to
698bbb1
Compare
- Isolate code that has changed in behaviour since version 20 and use
clang-format off comments to ignore
- CoroutineScheduler.h and VulkanDevice.h for
operator bool()
- VulkanDevice.cpp for re-aligned declarations
- RenderPasses.cpp for re-aligned function signature
- update CI workflows for all OSs to use version 22
MathewBensonCode
force-pushed
the
update-llvm
branch
from
698bbb1 to
c006273
Compare
|
Updated this to support llvm version 22, which is now the current stable version. I also all the CIs including the clang-format steps to use clang-format version 22. I isolated the few areas which have issues in the newer versions by excluding them using This means that we should be able to work with any version from 20 upto 22, and even older(but haven't tested those) |
3 participants
Closes #484