Modified code for exporting eval pcd#20
Open
dongjae0107 wants to merge 2 commits intoKTH-RPL:mainfrom
Open
Conversation
Member
|
I see. Thanks for your pull request. Your way is more on voxel-way using the grid bounding to check where the original one is mainly based on the nearest neighbor distance. I may prefer the latter one still since some methods can save at point-level, and voxel-way will inflate the score in some way. Maybe we need comparison results to show the benchmark methods' score change. Could you also attache a table for that if it's possible? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :)
How about slightly modifying the logic in 'export_eval_pcd.cpp' that marks 'gt_point' as dynamic? Currently, with a voxel size of 0.1, if the 'nearest_point' in 'et_cloud' is farther than 0.05 (half of the voxel size), 'gt_point' is classified as dynamic. However, when using the voxel downsampling method, which marks the space that the voxel spans, a more accurate approach might be to check if 'gt_point' falls within the space that 'nearest_point' spans before marking gt_point as dynamic. This would improve the accuracy of the classification.