Remove spotless line ending restriction#23
Open
roro1506HD wants to merge 1 commit intoLegacy-Visuals-Project:multiverfrom
Open
Remove spotless line ending restriction#23roro1506HD wants to merge 1 commit intoLegacy-Visuals-Project:multiverfrom
roro1506HD wants to merge 1 commit intoLegacy-Visuals-Project:multiverfrom
Conversation
Member
|
I'm on windows? And it builds just fine |
Contributor
Author
|
Are you using some special flags? When running And when running |
Member
|
Run spotlessApply |
Contributor
Author
|
When running that task, it changes every .java file with UNIX line endings, which then makes git want to push them at any time: It's basically either git wants to push UNIX line endings, or I cannot compile without removing the spotless check |
Member
|
Hmm, i've had it show them in intellij before like that but upon committing/pushing, it sees nothing changed and only pushes what really changed and makes them dissapear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the spotless line endings restriction to UNIX. This makes the mod able to be built on Windows machines, which was unable to be done before this change because every java file of the project is encoded using Windows line endings