refactor(search-reservations): replace native date inputs with flatpickr#1082
Merged
JohnVillalovos merged 1 commit intodevelopfrom Feb 28, 2026
Merged
refactor(search-reservations): replace native date inputs with flatpickr#1082JohnVillalovos merged 1 commit intodevelopfrom
JohnVillalovos merged 1 commit intodevelopfrom
Conversation
Collaborator
JohnVillalovos
commented
Feb 25, 2026
- Convert begin/end date fields from native inputs to text to use flatpickr
- Use document.getElementById for element access instead of jQuery
- Replace jQuery .change() with .on('change') for event handling
- Add setFlatpickrDisabled(input, disabled) to properly enable/disable flatpickr and its altInput
- Close flatpickr calendar when disabled
- Remove unused hidden formatted date inputs and AltId usage in DatePickerSetupControl
- Drop resourcePopup.js and Qtip includes
- Remove obsolete hover highlight code
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Search Reservations UI to rely on Flatpickr-driven date inputs (instead of native <input type="date"> + hidden formatted fields) and reduces jQuery usage / legacy dependencies on that page.
Changes:
- Convert begin/end date fields to text inputs that submit directly via
{formname ...}and initialize viaDatePickerSetupControl(Flatpickr). - Update
reservation-search.jsevent wiring and add a helper to properly enable/disable Flatpickr inputs (includingaltInput). - Remove Qtip/resource popup includes and obsolete hover-highlight code.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tpl/Search/search-reservations.tpl |
Replaces native date inputs + hidden formatted fields with Flatpickr setup; removes Qtip/resourcePopup includes. |
Web/scripts/reservation-search.js |
Refactors date element access and range-change handling; adds Flatpickr-aware enable/disable behavior. |
fee0fdb to
91f807d
Compare
- Convert begin/end date fields from native inputs to text to use flatpickr
- Use document.getElementById for element access instead of jQuery
- Replace jQuery .change() with .on('change') for event handling
- Add setFlatpickrDisabled(input, disabled) to properly enable/disable flatpickr and its altInput
- Close flatpickr calendar when disabled
- Remove unused hidden formatted date inputs and AltId usage in DatePickerSetupControl
- Drop resourcePopup.js and Qtip includes
- Remove obsolete hover highlight code
91f807d to
17449e2
Compare
Collaborator
Author
|
Thanks @labmecanicatec LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.