Skip to content

Replace non-functional 64-bit long int CMS updaters with int64 types #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BsAtHome wants to merge 2 commits into
base: master
Choose a base branch
from
+312 −291
Open

Replace non-functional 64-bit long int CMS updaters with int64 types #3803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efe4ef2
nml+cms: Replace non-functional 64-bit long int updaters with functio…
BsAtHome Feb 13, 2026
b87d3ce
nml+cms: Update all update functions to use [u]int{8,16,32,64}_t types.
BsAtHome Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/libnml/cms/cms.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,7 +1292,7 @@ CMS_STATUS CMS::update(bool &x)
}
}

CMS_STATUS CMS::update(char &x)
CMS_STATUS CMS::update(int8_t &x)
{
if (NULL != updater) {
return (updater->update(x));
Expand All @@ -1301,7 +1301,7 @@ CMS_STATUS CMS::update(char &x)
}
}

CMS_STATUS CMS::update(unsigned char &x)
CMS_STATUS CMS::update(uint8_t &x)
{
if (NULL != updater) {
return (updater->update(x));
Expand All @@ -1310,7 +1310,7 @@ CMS_STATUS CMS::update(unsigned char &x)
}
}

CMS_STATUS CMS::update(short int &x)
CMS_STATUS CMS::update(int16_t &x)
{
if (NULL != updater) {
return (updater->update(x));
Expand All @@ -1319,7 +1319,7 @@ CMS_STATUS CMS::update(short int &x)
}
}

CMS_STATUS CMS::update(unsigned short int &x)
CMS_STATUS CMS::update(uint16_t &x)
{
if (NULL != updater) {
return (updater->update(x));
Expand All @@ -1328,7 +1328,7 @@ CMS_STATUS CMS::update(unsigned short int &x)
}
}

CMS_STATUS CMS::update(int &x)
CMS_STATUS CMS::update(int32_t &x)
{
if (NULL != updater) {
return (updater->update(x));
Expand All @@ -1337,7 +1337,7 @@ CMS_STATUS CMS::update(int &x)
}
}

CMS_STATUS CMS::update(unsigned int &x)
CMS_STATUS CMS::update(uint32_t &x)
{
if (NULL != updater) {
return (updater->update(x));
Expand All @@ -1346,7 +1346,7 @@ CMS_STATUS CMS::update(unsigned int &x)
}
}

CMS_STATUS CMS::update(long int &x)
CMS_STATUS CMS::update(int64_t &x)
{
if (NULL != updater) {
return (updater->update(x));
Expand All @@ -1355,7 +1355,7 @@ CMS_STATUS CMS::update(long int &x)
}
}

CMS_STATUS CMS::update(unsigned long int &x)
CMS_STATUS CMS::update(uint64_t &x)
{
if (NULL != updater) {
return (updater->update(x));
Expand Down Expand Up @@ -1391,7 +1391,7 @@ CMS_STATUS CMS::update(long double &x)
}
}

CMS_STATUS CMS::update(char *x, unsigned int len)
CMS_STATUS CMS::update(int8_t *x, unsigned int len)
{
if (NULL != updater) {
return (updater->update(x, len));
Expand All @@ -1400,7 +1400,7 @@ CMS_STATUS CMS::update(char *x, unsigned int len)
}
}

CMS_STATUS CMS::update(unsigned char *x, unsigned int len)
CMS_STATUS CMS::update(uint8_t *x, unsigned int len)
{
if (NULL != updater) {
return (updater->update(x, len));
Expand All @@ -1409,7 +1409,7 @@ CMS_STATUS CMS::update(unsigned char *x, unsigned int len)
}
}

CMS_STATUS CMS::update(short *x, unsigned int len)
CMS_STATUS CMS::update(int16_t *x, unsigned int len)
{
if (NULL != updater) {
return (updater->update(x, len));
Expand All @@ -1418,7 +1418,7 @@ CMS_STATUS CMS::update(short *x, unsigned int len)
}
}

CMS_STATUS CMS::update(unsigned short *x, unsigned int len)
CMS_STATUS CMS::update(uint16_t *x, unsigned int len)
{
if (NULL != updater) {
return (updater->update(x, len));
Expand All @@ -1427,7 +1427,7 @@ CMS_STATUS CMS::update(unsigned short *x, unsigned int len)
}
}

CMS_STATUS CMS::update(int *x, unsigned int len)
CMS_STATUS CMS::update(int32_t *x, unsigned int len)
{
if (NULL != updater) {
return (updater->update(x, len));
Expand All @@ -1436,7 +1436,7 @@ CMS_STATUS CMS::update(int *x, unsigned int len)
}
}

CMS_STATUS CMS::update(unsigned int *x, unsigned int len)
CMS_STATUS CMS::update(uint32_t *x, unsigned int len)
{
if (NULL != updater) {
return (updater->update(x, len));
Expand All @@ -1445,7 +1445,7 @@ CMS_STATUS CMS::update(unsigned int *x, unsigned int len)
}
}

CMS_STATUS CMS::update(long *x, unsigned int len)
CMS_STATUS CMS::update(int64_t *x, unsigned int len)
{
if (NULL != updater) {
return (updater->update(x, len));
Expand All @@ -1454,7 +1454,7 @@ CMS_STATUS CMS::update(long *x, unsigned int len)
}
}

CMS_STATUS CMS::update(unsigned long *x, unsigned int len)
CMS_STATUS CMS::update(uint64_t *x, unsigned int len)
{
if (NULL != updater) {
return (updater->update(x, len));
Expand Down
39 changes: 21 additions & 18 deletions src/libnml/cms/cms.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
#ifndef CMS_HH
#define CMS_HH

#include <stdint.h>

#ifdef __cplusplus
extern "C" {
#endif
Expand Down Expand Up @@ -263,27 +265,28 @@ class CMS {
/***********************************************/
/* Access functions for primitive C language data types */
CMS_STATUS update(bool &x);
CMS_STATUS update(char &x); /* Used by emc2 */
CMS_STATUS update(unsigned char &x); /* Used by emc2 */
CMS_STATUS update(short int &x);
CMS_STATUS update(unsigned short int &x);
CMS_STATUS update(int &x); /* Used by emc2 */
CMS_STATUS update(unsigned int &x);
CMS_STATUS update(long int &x); /* Used by emc2 */
CMS_STATUS update(unsigned long int &x); /* Used by emc2 */
CMS_STATUS update(int8_t &x);
CMS_STATUS update(uint8_t &x);
CMS_STATUS update(int16_t &x);
CMS_STATUS update(uint16_t &x);
CMS_STATUS update(int32_t &x);
CMS_STATUS update(uint32_t &x);
CMS_STATUS update(int64_t &x);
CMS_STATUS update(uint64_t &x);
CMS_STATUS update(float &x);
CMS_STATUS update(double &x); /* Used by emc2 */
CMS_STATUS update(double &x);
CMS_STATUS update(long double &x);
CMS_STATUS update(char *x, unsigned int len); /* Used by emc2 */
CMS_STATUS update(unsigned char *x, unsigned int len); /* Used by emc2 */
CMS_STATUS update(short *x, unsigned int len);
CMS_STATUS update(unsigned short *x, unsigned int len);
CMS_STATUS update(int *x, unsigned int len); /* Used by emc2 */
CMS_STATUS update(unsigned int *x, unsigned int len);
CMS_STATUS update(long *x, unsigned int len);
CMS_STATUS update(unsigned long *x, unsigned int len);
CMS_STATUS update(char *x, unsigned int len) { return update(reinterpret_cast<int8_t *>(x), len); };
CMS_STATUS update(int8_t *x, unsigned int len);
CMS_STATUS update(uint8_t *x, unsigned int len);
CMS_STATUS update(int16_t *x, unsigned int len);
CMS_STATUS update(uint16_t *x, unsigned int len);
CMS_STATUS update(int32_t *x, unsigned int len);
CMS_STATUS update(uint32_t *x, unsigned int len);
CMS_STATUS update(int64_t *x, unsigned int len);
CMS_STATUS update(uint64_t *x, unsigned int len);
CMS_STATUS update(float *x, unsigned int len);
CMS_STATUS update(double *x, unsigned int len); /* Used by emc2 */
CMS_STATUS update(double *x, unsigned int len);
CMS_STATUS update(long double *x, unsigned int len);

/*************************************************************************
Expand Down
Loading
Loading