feat(linux/wlr): Implement ext-image-copy-capture#4788
Draft
Dregu wants to merge 1 commit intoLizardByte:masterfrom
Draft
feat(linux/wlr): Implement ext-image-copy-capture#4788Dregu wants to merge 1 commit intoLizardByte:masterfrom
Dregu wants to merge 1 commit intoLizardByte:masterfrom
Conversation
Member
|
Thanks! It seems the PR was not based on an updated version of master. Could you rebase it? |
Contributor
Author
|
Yeah sure next week, I just pushed it as a placeholder. |
9c69036 to
a531c36
Compare
Adds the new image-copy-capture protocol in staging as primary backend for the wayland capture method, but keeps wlr-screencopy as a fallback Also supports actual output names in output_name
Contributor
Author
|
I hate submodules. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




I'm putting this draft up simply because these linux prs keep popping up every day and by monday three more people will have implemented this probably, so it would be silly to keep it to myself when it's already pretty much done.
Description
Adds the ext-image-copy-capture protocol as primary backend for the wayland capture method, but keeps wlr-screencopy as a fallback, as it is still slightly better supported. Also supports actual output names in output_name, like that other pr.
There's really no hurry to switch to icc from screencopy, but it is an unstable deprecated proto and will be gone next year. I just decided to do this one night since hyprland got icc support now and it seemed neat. My thoughts on this are not very collected, but it probably works.
I don't know jack about drm modifiers or frankly these protocols, so I've pretty much winged it to work on my machine.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage