bug fix for transform when using cuml.hdbscan &calculate_probabilities=True#1543
Closed
wwdda wants to merge 1 commit intoMaartenGr:masterfrom
Closed
bug fix for transform when using cuml.hdbscan &calculate_probabilities=True#1543wwdda wants to merge 1 commit intoMaartenGr:masterfrom
wwdda wants to merge 1 commit intoMaartenGr:masterfrom
Conversation
Owner
Author
Thanks for your response @MaartenGr. Sorry for the duplicate which I didn't notice when I searched for a solution to the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @MaartenGr,
Regarding the issue #1463, I also come across the same issue when trying
transform()withcuml HDBSCANandcalculate_probabilities=True.Below is the code for reproducing this issue:
I modified the membership_vector clause in hdbscan_delegator and fixed this issue. I think this modification also aligns with the other two conditional clauses.
For your information, below are my running environments.
Operating System: Ubuntu 20.04 LTS
Version: bertopic 0.15.0
Other: installed by pip, python=3.10.13, cuml=23.08(stable)