MDEV-29466: Rename description_event_for_exec to description_event_for_sql_thread#4668
Closed
ChandanaRamakrishna wants to merge 12 commits intoMariaDB:mainfrom
Closed
Conversation
…ck-buffer-overflow in Binary_string::q_append, and Assertion `str.alloced_length() >= str.length() + data_len' failed in spider_string::q_append on SELECT. The buffer size has to be increased because we store the hexadecimal representation of the data which takes twice it's length plust the '0x' starter. Also string representation of the long should be increased.
We have to take the ending of a polygon into account. So the order of checking the scan changed.
Add check for the arguments.
Adding test cases for abs() .
Starting with MariaDB Server 10.11, the test innodb.xa_recovery would consume innodb_lock_wait_timeout (default: 50) extra seconds. The exact difference between 10.6 and 10.11 is not known, but the issue is that a client disconnect fails to abort a lock wait. Let us set a minimal timeout for the problematic statement in order to allow the test to complete faster.
Setting mroonga_default_tokenizer to NULL caused a server crash because the update function did not handle the NULL value before passing it to strcmp. Handle NULL values by treating them as "off" to allow safe variable reset.
Align with existing mroonga memory management patterns to ensure consistency, rather than relying on the MariaDB framework default behavior.
Add copyright header to the test file. Disable the test in embedded mode by sourcing include/not_embedded.inc."
…nnodb_file_per_table setting Problem: ======= InnoDB DDL does ALTER TABLE PAGE_COMPRESSED=1 because: 1. check_if_supported_inplace_alter() reads srv_file_per_table during precheck and does allow INSTANT operation. 2. User does change innodb_file_per_table later. But prepare phase read srv_file_per_table again during execution. 3. If the global variable changed between these phases, causes server abort for page_compressed tables. Solution: ========= - Add a file_per_table member to Alter_inplace_info to capture the innodb_file_per_table value during the precheck phase and use that consistent value throughout the entire ALTER TABLE operation. - Converted boolean flags (online, ignore, error_if_not_empty, mdl_exclusive_after_prepare) from individual boolean members to bitfields packed in a single byte - Reduced Alter_inplace_info structure size by 24 bytes
gkodinov
added
the
External Contribution
gkodinov
requested changes
Feb 20, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
This is a preliminary review. Thank you for rebasing this to 10.6.
Please update your commit's text so that it complies to CODING_STANDARDS.md.
…_sql_thread Pure rename for clarity. No functional changes.
ChandanaRamakrishna
force-pushed
the
MDEV-29466-rename-description-event-10.6
branch
from
b06759a to
ad7bc15
Compare
Contributor
Author
|
Updated the commit message to comply with CODING_STANDARDS.md. |
Contributor
Author
|
Thank you for the review!
…On Fri, 20 Feb 2026 at 16:33, Georgi Kodinov ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM now. thanks.
—
Reply to this email directly, view it on GitHub
<#4668 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3O75UGWV4FSLIA3TDHLDSL4M3SXFAVCNFSM6AAAAACVW3J6CKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMZRGQ2TKNBQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Dear Chandana, thanks for a good piece of help! I am sorry not to have made it clear earlier that the patch would be better off to go to 13.0. If you don't mind, could you please rebase your work onto the current main branch? Cheers, |
Contributor
Author
|
Hi Andrei,
I have rebased the change onto current main and applied the rename directly
there.
Please let me know if any further adjustments are needed.
Thanks!
…On Fri, 20 Feb 2026 at 17:18, andrelkin ***@***.***> wrote:
*andrelkin* left a comment (MariaDB/server#4668)
<#4668 (comment)>
Dear Chandana <https://github.com/ChandanaRamakrishna>, thanks for a good
piece of help!
I am sorry not to have made it clear earlier that the patch would be
better off to go to 13.0.
At this point it fits more to refactoring and can't be anyway disturbing
to those who deeply rooted to the old name,
while also at fixing functional bugs.
If you don't mind, could you please rebase your work onto the current main
branch?
Cheers,
Andrei
—
Reply to this email directly, view it on GitHub
<#4668 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3O75UDFH7CVH2RDRDUDKNT4M3YBHAVCNFSM6AAAAACVW3J6CKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMZTGUZTCNZTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Howdy Chandana!
I only see the 10.6-based commit 😇 |
Contributor
|
Chandana, the rebased patch looks good. Thanks for a good piece of work and your patience! I am approving it. PS. I am not sure why this PR was closed though, it probably only needed the rebase to |
Contributor
Author
|
Hi Andrei,
Thank you for the review and approval — I really appreciate your feedback
and guidance throughout the process.
Regarding the previous PR, I closed it to avoid confusion with the
10.6-based history when switching to main. Apologies if that caused any
inconvenience.
Thanks again!
…On Mon, 23 Feb 2026 at 23:10, andrelkin ***@***.***> wrote:
*andrelkin* left a comment (MariaDB/server#4668)
<#4668 (comment)>
Chandana, the rebased patch looks good. Thanks for a good piece of work
and your patience!
I am approving it.
PS. I am not sure why this PR was closed though, it probably only needed
the rebase to main..
—
Reply to this email directly, view it on GitHub
<#4668 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3O75UBPHP7BKOGPIHGFHIT4NM3PXAVCNFSM6AAAAACVW3J6CKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNBWGI4TGNRYGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed description_event_for_exec to description_event_for_sql_thread
for clarity, since it is used by the SQL thread.
No functional changes.
Based on 10.6 as requested.