Fix explicit compose file path resolution#64
Open
ravshansbox wants to merge 2 commits intoMcrich23:mainfrom
Open
Fix explicit compose file path resolution#64ravshansbox wants to merge 2 commits intoMcrich23:mainfrom
ravshansbox wants to merge 2 commits intoMcrich23:mainfrom
Conversation
Owner
|
The original intent of this flag was for it to be relative for those who want a different compose file in their folder. I totally see why this could be frustrating for someone who may want to use an absolute path instead. Let me do some code review and we can move forward from there. |
Mcrich23
requested changes
Mar 14, 2026
Owner
Mcrich23
left a comment
There was a problem hiding this comment.
It looks pretty good, just a couple issues. Thanks for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-f/--fileinput instead of treatingcompose.ymlas a sentinelenv_file, build context, and Dockerfile paths from the compose file directoryProblem
The existing code always derived
composePathfrom"\(cwd)/\(composeFilename)", which breaks absolute compose file paths and conflates default behavior with explicit user input.Changes
composeFilenamefrom a magic default string toString?inComposeUpandComposeDownresolvedPath(for:relativeTo:)helpercomposePathand run it only when no explicit file was passedenv_file, build context, and Dockerfile paths relative to the compose file directory inComposeUpVerification
swift build./.build/debug/Container-Compose down -f /Users/user/projects/project/docker-compose.ymlFixes #63