Fix CI: update vdiffr snapshots, fix Rd docs, add Copilot setup#45
Fix CI: update vdiffr snapshots, fix Rd docs, add Copilot setup#45
Conversation
…aph() Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
yihui
left a comment
There was a problem hiding this comment.
why were transition boxes lost in the new svg snapshots?
| To run `R CMD check` locally: | ||
|
|
||
| ```r | ||
| # Install check dependencies | ||
| install.packages("rcmdcheck") | ||
|
|
||
| # Run the check | ||
| rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning") | ||
| ``` | ||
|
|
||
| Or using devtools: | ||
|
|
||
| ```r | ||
| devtools::check() | ||
| ``` |
There was a problem hiding this comment.
dont' use any packages; simply run command line R CMD check
There was a problem hiding this comment.
Updated in ec59bf9 to use R CMD build . && R CMD check --no-manual --as-cran *.tar.gz.
.github/copilot-instructions.md
Outdated
|
|
||
| ### Common issues to watch for | ||
|
|
||
| - **Documentation mismatches**: If you add or rename function parameters, update the corresponding `man/*.Rd` file and the `@param` roxygen2 tags in the source `R/*.R` file. |
There was a problem hiding this comment.
that's not the way to update documentation: run roxygen2::roxygenize() instead
.github/copilot-instructions.md
Outdated
|
|
||
| Then commit the updated SVG files in `tests/testthat/_snaps/hgraph/`. | ||
|
|
||
| - **NAMESPACE**: If you add new imports or exports, update `NAMESPACE` using `devtools::document()`. |
There was a problem hiding this comment.
merge this item with the documentation item: in general, always run roxygen2 after making changes in source code to update documentation, namespace, etc.
There was a problem hiding this comment.
Merged into a single "Documentation and NAMESPACE" bullet in ec59bf9.
R/hgraph.R
Outdated
| curvedflag = TRUE, | ||
| curvature = 0.5, |
There was a problem hiding this comment.
no need to add two args: curvature alone would be enough---curvature == 0 means segments
There was a problem hiding this comment.
Removed curvedflag in ec59bf9. Now curvature = 0 draws straight segments (geom_segment), and any non-zero value draws curves (geom_curve).
…nerate snapshots, update copilot instructions Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
There was an operator precedence bug in R: |
curvedflagparam; usecurvature == 0for straight lines (reviewer feedback)if/elseinside ggplot+chain was silently droppinggeom_rectandgeom_textlayers when curvedflag=TRUE (transition boxes were missing from all snapshots)R CMD checkCLI, useroxygen2::roxygenize()for docs/NAMESPACE, merge documentation+NAMESPACE bulletsOriginal prompt
geom_line()withgeom_curve()#43💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.