Remove low-pass filter from gestures#240
Open
EMaksymenko wants to merge 1 commit intoNASAWorldWind:developfrom
Open
Remove low-pass filter from gestures#240EMaksymenko wants to merge 1 commit intoNASAWorldWind:developfrom
EMaksymenko wants to merge 1 commit intoNASAWorldWind:developfrom
Conversation
…zer to fix 180 degree rotation issue.
EMaksymenko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Remove low-pass filter from gestures, especially from RotationRecognizer.
Why Should This Be In Core?
It makes a bug during rotation gesture over 360 degrees due to Kalman filter between 0 and 360 degrees gives unexpected behavior, plus filter adds input lag to gestures.
Benefits
Normal user input behavior without lag, especially rotation gesture.
Potential Drawbacks
None