Conversation
copie_session fixture
egpbos
reviewed
Jul 31, 2024
Collaborator
egpbos
left a comment
There was a problem hiding this comment.
This would be great, but When Is This Coming Exactly?™ :P
Change request: please also remove the here import and the associated dependency (I forget its name).
Contributor
Author
|
@egpbos good catch, Can't say when Soon™ is exactly, but it's active work in progress :) |
3 tasks
6f7cec0 to
f5e8634
Compare
Contributor
Author
|
@egpbos the |
f5e8634 to
982a89e
Compare
Collaborator
|
Thanks for merging this, sorry for not replying :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pytest-cookieshad acookies_sessionfixture, butpytest-copiedid not yet have an equivalent when first switching from cookiecutter to copier. Since thiswill be added soon$^\text{tm}$ has recently been added, we can go back to using a dedicated fixture rather than creating such a session scoped template instance ourselvespytest-copie, this PR will be marked as ready