Add DistributedInitConfig

[maanug-nv]

What does this PR do ?

Rewrite of #2623 on top of latest main .

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]

Loading

Pre-checks

• I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
• I have added relevant unit tests
• I have added relevant functional tests
• I have added proper typing to my code Typing guidelines
• I have added relevant documentation
• I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

1. Attach the Expert Review label when your PR is ready for review.
2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

1. Add Final Review label
2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch

The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

[maanug-nv]

@jaredcasper Do you know why this is a action="store" instead of action="store_true" like most other boolean settings?
Behavior is unusual. Not sure if we should avoid breaking it, or just switch to 'store_true'.

from argparse import ArgumentParser


if __name__ == "__main__":
    parser = ArgumentParser()
    parser.add_argument("--lazy-mpu-init", type=bool, required=False)
    args = parser.parse_args()

    print(args)

Launches:

maanug@ec08e03-lcelt:~$ python test-mpu.py
Namespace(lazy_mpu_init=None)

maanug@ec08e03-lcelt:~$ python test-mpu.py --lazy-mpu-init
usage: test-mpu.py [-h] [--lazy-mpu-init LAZY_MPU_INIT]
test-mpu.py: error: argument --lazy-mpu-init: expected one argument

maanug@ec08e03-lcelt:~$ python test-mpu.py --lazy-mpu-init True
Namespace(lazy_mpu_init=True)

maanug@ec08e03-lcelt:~$ python test-mpu.py --lazy-mpu-init False
Namespace(lazy_mpu_init=True)