devices have different upper and lower temperature bounds depending on the car's current state.#350
Open
devices have different upper and lower temperature bounds depending on the car's current state.#350
Conversation
…nd lower temperature bounds
jr1221
requested changes
Aug 15, 2025
Contributor
jr1221
left a comment
jr1221
left a comment
There was a problem hiding this comment.
very cool. Please add a default state used if no other states are used. be careful about garbage data here, please read about tagged unions or doing NULL checks.
| bool below_min_temp = temp < device_bounds.lower_motor_temp_bound; | ||
|
|
||
| if (above_max_temp) { | ||
| debounce(above_max_temp, &(device->timer), 10000, set_device_on, |
Contributor
There was a problem hiding this comment.
please #define the time for debounce (might already exist)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devices have different upper and lower temperature bounds depending on the car's current state.
Changes
added a struct and sub-struct to hold each cooling device's temperature bounds for each possible car state.
Changed the debounce function to check temperature against bounds for the current car state.
Notes
This will probably be changed soon to allow a csv to be read in to set the upper and lower temp bounds.
Closes #329