Harden simulation and reference comparison validation#29
Merged
AnHeuermann merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
- Fail run_simulate when sol.t is empty or the system has no states or observed variables, preventing empty CSVs and downstream panics - Include observed variables in the simulation CSV output so models without state variables (e.g. BusUsage) still produce usable results - Fail compare_with_reference (instead of skip) when reference signals are absent from the simulation; write NaN sim/relerr columns for signals with no simulation counterpart - Validate upfront that all comparisonSignals.txt entries exist in the reference CSV, and error if the simulation time interval does not cover the reference interval - Extend the per-model status line to show a CMP OK/FAIL phase and signal counts including skipped signals Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Some models seem to pass simulation but aren't producing any results, e.g.
Modelica.Blocks.Examples.BusUsage:The issue is that the simulation result has no time points at all. Simulation and verification stages should fail in this case.
Changes