Handle UserAlerts and ManufacturerSpecificDBReady notifications#208
Open
nickrbogdanov wants to merge 1 commit intoOpenZWave:masterfrom
Open
Handle UserAlerts and ManufacturerSpecificDBReady notifications#208nickrbogdanov wants to merge 1 commit intoOpenZWave:masterfrom
nickrbogdanov wants to merge 1 commit intoOpenZWave:masterfrom
Conversation
On installations where the /etc/openzwave device configuration database
is missing files, the Python wrapper can generate these unhelpful errors:
2021-04-09 09:01:26,267 notif_callback : new notification
2021-04-09 09:01:26,268 notif_callback : Notification type : 30, nodeId : 0
2021-04-09 09:01:26,268 notif_callback exception
Traceback (most recent call last):
File "src-lib/libopenzwave/libopenzwave.pyx", line 512, in libopenzwave.notif_callback
IndexError: list index out of range
UnboundLocalError: local variable 'n' referenced before assignment
Exception ignored in: 'libopenzwave.notif_callback'
UnboundLocalError: local variable 'n' referenced before assignment
2021-04-09 09:01:26,269 notif_callback : new notification
2021-04-09 09:01:26,269 notif_callback : Notification type : 30, nodeId : 0
2021-04-09 09:01:26,269 notif_callback exception
Traceback (most recent call last):
File "src-lib/libopenzwave/libopenzwave.pyx", line 512, in libopenzwave.notif_callback
IndexError: list index out of range
They correspond to these messages in the C++ library's log:
2021-04-09 09:10:23.476 Warning, Config Revision of ManufacturerSpecific Database is out of date
2021-04-09 09:10:23.476 Info, Queuing download for http://download.db.openzwave.com/mfs.xml
2021-04-09 09:10:23.477 Warning, File Removal failed: /etc/openzwave/manufacturer_specific.xml
2021-04-09 09:10:23.477 Warning, File Transfer Failed. Could not Rotate Existing File: /etc/openzwave/manufacturer_specific.xml
2021-04-09 09:10:23.477 Warning, Can't download ManufacturerSpecifix.xml Config file
2021-04-09 09:10:23.477 Info, ManufacturerSpecificDB Initialized
2021-04-09 09:10:23.477 Detail, Notification: User Alert - Manufacturer_specific.xml out of Date
2021-04-09 09:10:23.478 Detail, Notification: A Config File Failed to download
2021-04-09 09:10:23.478 Detail, Notification: ManufacturerSpecificDB Ready
Update the Python wrapper to handle the notifications properly instead
of generating IndexError exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On installations where the /etc/openzwave device configuration database is missing files, the Python wrapper can generate these unhelpful errors:
They correspond to these messages in the C++ library's log:
Update the Python wrapper to handle the notifications properly instead of generating IndexError exceptions.