feat: Add validation for Foundry and Hardhat 3 build-info formats#1208
feat: Add validation for Foundry and Hardhat 3 build-info formats#1208
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
| Ensure you have compiled with Hardhat 3 so that artifacts/build-info/ contains both the main files and the .output.json files. | ||
| Then run: ${HARDHAT_COMPILE_COMMAND}`; |
There was a problem hiding this comment.
This sounds like it's telling the user to compile twice which is confusing.
Perhaps combine them:
| Ensure you have compiled with Hardhat 3 so that artifacts/build-info/ contains both the main files and the .output.json files. | |
| Then run: ${HARDHAT_COMPILE_COMMAND}`; | |
| Ensure you compile with Hardhat 3 so that artifacts/build-info/ contains both .json files and .output.json files: ${HARDHAT_COMPILE_COMMAND}`; |
There was a problem hiding this comment.
Is there anything that the user needs to do if build-info does not have both types of files? Or does that perhaps suggest they are using Hardhat 2 (which is not supported with this version)?
| Then run: ${FOUNDRY_COMPILE_COMMAND}`; | ||
|
|
||
| const HH3_BUILD_INFO_HELP = `\ | ||
| Hardhat 3 (HH3) build-info uses a main .json file (input, solcVersion) and a separate .output.json (output). |
There was a problem hiding this comment.
Let's not call it HH3 in messages (the acronym is not widely used).
| Hardhat 3 (HH3) build-info uses a main .json file (input, solcVersion) and a separate .output.json (output). | |
| Hardhat 3's build-info uses a main .json file (input, solcVersion) and a separate .output.json (output). |
|
Closing since this will be part of #1194 instead. |
We are having an issue with this PR #1194 CI/CD that depends on a deployed core package; this could be the fix for it.
still investigating, not finished yet.
Summary by CodeRabbit
Release Notes
Bug Fixes
Tests