Test - migration javascript to typescript#1109
Closed
opslevel[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Successfully migrated all remaining JavaScript source files to TypeScript, completing the gradual migration process. The migration involved converting three JavaScript files to TypeScript with proper type annotations and interface definitions, while maintaining backward compatibility with existing imports.
Key Changes
level_color_helper.jsto TypeScript with a newLevelColorinterface and strongly-typed function signatures for color palette managementmaturity_report_helper.jsto TypeScript with interfaces forLevel,LevelEntry,ServiceLevelCount, andCategoryLevelCount, ensuring type safety for data aggregation functionstextEncoder.jsto TypeScript using ES6 import syntax instead of CommonJSrequirejest.config.jsto reference the new TypeScript test setup filetsconfig.jsonto include all test TypeScript files with the patterntest/**/*.ts@ts-nocheckdirectives from migrated files, enabling full TypeScript strict checkingAll source files in the
srcandtestdirectories are now TypeScript, while configuration files (babel.config.js,jest.config.js,.eslintrc.js) remain in JavaScript as per common practice. The TypeScript compiler configuration already has@typescript-eslintparser and plugin configured, and the build tooling is properly set up to handle TypeScript alongside the existing JavaScript configuration files.