Average imputed earnings percentiles with national values#312
Open
vahid-ahmadi wants to merge 1 commit intomainfrom
Open
Average imputed earnings percentiles with national values#312vahid-ahmadi wants to merge 1 commit intomainfrom
vahid-ahmadi wants to merge 1 commit intomainfrom
Conversation
Missing ASHE percentiles (91-98, 100) were imputed using ratio scaling from national reference values alone. This causes instability for areas with unusual income tails. Now blends the ratio estimate with the national reference value (50/50 by default) to shrink extreme estimates. - Extract shared fill_missing_percentiles into earnings_percentiles.py - Add national_weight parameter (0=old behaviour, 0.5=default blend) - Remove duplicated code from LA and constituency target scripts - Add 8 unit tests covering preservation, blending, monotonicity Closes #68 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fill_missing_percentiles()andreference_valuesfrom both LA and constituency scripts into a sharedearnings_percentiles.pymodulenational_weightparameter controls blending: 0.0 = old behaviour (pure ratio), 0.5 = equal blend (default), 1.0 = pure nationalTest plan
Closes #68
🤖 Generated with Claude Code