WIP: Fix: PSUseConsistentWhitespace formatting for do-while, unary operators, and native commands#2114
Draft
DrSkillIssue wants to merge 5 commits intoPowerShell:mainfrom
Draft
WIP: Fix: PSUseConsistentWhitespace formatting for do-while, unary operators, and native commands#2114DrSkillIssue wants to merge 5 commits intoPowerShell:mainfrom
DrSkillIssue wants to merge 5 commits intoPowerShell:mainfrom
Conversation
Author
6 tasks
Collaborator
|
@DrSkillIssue Can you please resolve merge conflict and re-test please. This is due to PR #2140 , which tweaked the logic of the same area of the rule you modify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes multiple whitespace formatting issues in
PSUseConsistentWhitespaceruleIssues Fixed:
docker --secret id=x,env=y)}and keywords in do-while/do-until loopsChanges Made:
Core Fixes:
FindKeywordAfterBraceViolationsto handle keywords following closing bracesFindOperatorViolationsFindParameterViolationsto skip whitespace inside string literalsFindSeparatorViolationsfor native command argumentsUntil, Do, Else, Catch, FinallyTests Added:
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.