Skip to content

Add recent Orcfax projects#46

Open
ross-spencer wants to merge 1 commit intoProofOfCardano:mainfrom
orcfax:main
Open

Add recent Orcfax projects#46
ross-spencer wants to merge 1 commit intoProofOfCardano:mainfrom
orcfax:main

Conversation

@ross-spencer
Copy link

No description provided.

@Mercurial
Copy link
Collaborator

Hey @ross-spencer, thanks for adding Orcfax! There are two issues to fix before we can merge:

1. Duplicate entry
Orcfax and CNT Collector Node both point to the exact same repo (orcfax/cnt-collector-node). One of these should be removed.

2. Invalid GitHub org names
GitHub org names cannot contain dots (.), so "owner": "orcfax.io" and "owner": "kompact.io" won't resolve. The correct GitHub org for Orcfax is just orcfax. Please double-check the correct org names for the other entries (Simple Sign, CER Feeds, Explorer, Oracle Suite, Subbit).

Once those are corrected we're good to merge!

@Mercurial
Copy link
Collaborator

Adding a bit more detail on the org name issue:

GitHub usernames and org names only support alphanumeric characters and hyphens — dots are not allowed. So orcfax.io and kompact.io are not valid GitHub org identifiers and will return 404 when the bot tries to query them.

We verified this against the GitHub API:

  • github.com/orcfax.io → 404 (does not exist)
  • github.com/kompact.io → 404 (does not exist)
  • github.com/orcfax → ✅ exists (this is the correct org)

So for the Orcfax entries, "owner": "orcfax.io" should be "owner": "orcfax". You'd also want to double-check that the repo names (e.g. simple-sign, cer-feeds, explorer.orcfax.io, oracle-suite) actually exist under the orcfax org before adding them.

For the Subbit entry (kompact.io), you'd need to find their actual GitHub org handle — if they don't have a public one the entry can't be tracked by the bot.

@ross-spencer
Copy link
Author

cheers @Mercurial some copy and pasta going on there. I started to add Orcfax as an Org and then realized you wanted projects.

I've made the requested changes and then rebased against your main branch. It should be looking better now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants