Skip to content

Add aggregate_time support to convert_and_aggregate#491

Open
FabianHofmann wants to merge 1 commit intomasterfrom
feat/aggregate_time
Open

Add aggregate_time support to convert_and_aggregate#491
FabianHofmann wants to merge 1 commit intomasterfrom
feat/aggregate_time

Conversation

@FabianHofmann
Copy link
Contributor

Closes #489.

Changes proposed in this Pull Request

  • add aggregate_time={"sum", "mean", False} to convert_and_aggregate to control temporal aggregation explicitly
  • preserve the historical default behavior with aggregate_time=None
    • without spatial aggregation: sum over time
    • with spatial aggregation: return the full time series
  • deprecate capacity_factor and capacity_factor_timeseries in favor of aggregate_time
  • apply temporal aggregation consistently for both spatially aggregated and non-aggregated results
  • update wind() and pv() examples to use aggregate_time=False
  • add focused tests for temporal aggregation, deprecated arguments, and invalid argument validation
  • add an upcoming-release note for the API change

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert & Aggregate redesign

1 participant