Make LinearExpression multiplication with constant containing subset of dimensions consistent with Variable behaviour#571
Closed
RobbieKiwi wants to merge 1 commit intoPyPSA:masterfrom
Conversation
9 tasks
Contributor
Author
|
@FabianHofmann I like your PR #572 better so I will close this one |
FBumann
added a commit
that referenced
this pull request
Mar 14, 2026
Documents 5 categories of legacy issues with paired legacy/v1 tests: 1. Positional alignment (#586, #550): same-shape operands with different labels silently paired by position, producing wrong results 2. Subset constant associativity (#572): left-join drops coordinates, making (a+c)+b != a+(c+b) 3. User NaN swallowed (#620): NaN in user data silently filled with inconsistent neutral elements (0 for add/mul, 1 for div) 4. Variable vs Expression inconsistency (#569, #571): x*c and (1*x)*c previously gave different results 5. Absent slot propagation (#620): legacy can't distinguish absent variables from zero, fillna() is a no-op Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #569 #570
Changes proposed in this Pull Request
Now LinearExpression behaves the same way as Variable when multiplying with a constant containing a susbet of dimensions. Still it is not consistent with addition.
For addition, when a coord is mising we just add 0 (I.e do nothing at that coord)
Perhaps the equivalent for multiplication would be to multiply by 1 (also do nothing) rather than fill with nan?
Checklist
doc.doc/release_notes.rstof the upcoming release is included.