Conversation
david-rfai
left a comment
There was a problem hiding this comment.
See comments, and also look into other ways of combining evals and fit functions/classes. Would also be nice if the database could abstract the metrics logger, so there does not need to be dedicated columns for different trackers.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Changes
--tracking-backendflag forrapidfireai startchanged to--tracking-backendsto now allow multiple flags with one of the following: mlflow, tensorboard, trackiomlflow_run_idcolumn in database tometric_run_idto be more generic for metrics loggermlflow_experiment_idcolumn in databasse tometric_experment_idto be more generic for metrics loggerevalsandfitmetric_rfmetric_manageras Metrics manager that accepts one or more Metrics loggersNote
Introduces a unified metrics layer and migrates the codebase off MLflow-only assumptions.
RFMetricLoggerwith backends: MLflow, TensorBoard, TrackIO; implement per-backend managers and default selection viaRF_MLFLOW_ENABLED,RF_TENSORBOARD_ENABLED,RF_TRACKIO_ENABLEDmlflow_*→metric_*), controller/worker/experiment now create/log/end runs viametric_manager--tracking-backends(multi-select) replaces--tracking-backend; sets new env flags; add--forcefor non-interactive shutdownMetricLoggingCallback; Generation metrics usetorch.amp.autocast("cuda"); trainer and configs updated to passmetric_run_idtrackio, optionalizemlflow, setRF_TENSORBOARD_LOG_DIRdefault)Written by Cursor Bugbot for commit eb6153f. This will update automatically on new commits. Configure here.